Bug 49568 - [Qt] ZoomTextOnly doesn't work
Summary: [Qt] ZoomTextOnly doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Yi Shen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-15 15:25 PST by Yi Shen
Modified: 2010-11-17 06:29 PST (History)
6 users (show)

See Also:

Attachments
first try (2.55 KB, patch)
2010-11-15 15:35 PST, Yi Shen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yi Shen 2010-11-15 15:25:16 PST 
User can set ZoomTextOnly in the QWebSetting, however, qwebframe doesn't check the ZoomTextOnly attribute when applying the zoom...
Comment 1 Yi Shen 2010-11-15 15:35:41 PST 
Created attachment 73938 [details]
first try
Comment 2 Andreas Kling 2010-11-15 15:45:48 PST 
Comment on attachment 73938 [details]
first try

Nice catch! r=me
Comment 3 Yi Shen 2010-11-15 15:56:39 PST 
(In reply to comment #2)
> (From update of attachment 73938 [details])
> Nice catch! r=me

Thanks for quick review, kling :)
Comment 4 WebKit Commit Bot 2010-11-15 20:14:01 PST 
Comment on attachment 73938 [details]
first try

Clearing flags on attachment: 73938

Committed r72055: <http://trac.webkit.org/changeset/72055>
Comment 5 WebKit Commit Bot 2010-11-15 20:14:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-11-15 21:13:09 PST 
http://trac.webkit.org/changeset/72055 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
fast/block/float/015.html
Comment 7 Csaba Osztrogonác 2010-11-16 02:35:29 PST 
And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ...
Guys, could you watch the bots next time after commit?
Comment 8 Yi Shen 2010-11-16 04:52:45 PST 
(In reply to comment #7)
> And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ...
> Guys, could you watch the bots next time after commit?

oops, Sorry, I will look at the tests failed issue ASAP.
Comment 9 Yi Shen 2010-11-16 06:17:32 PST 
(In reply to comment #7)
> And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ...
> Guys, could you watch the bots next time after commit?

Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch.
Comment 10 Csaba Osztrogonác 2010-11-16 06:30:20 PST 
(In reply to comment #9)
> Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch.

I meant minor pixel differences caused by your patch and not this flakey test.
Comment 11 Yi Shen 2010-11-16 14:13:36 PST 
(In reply to comment #10)
> (In reply to comment #9)
> > Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch.
> 
> I meant minor pixel differences caused by your patch and not this flakey test.

I rolled back my changes but still see this test failed... hmmm, need take more time to look at it.
Comment 12 Yi Shen 2010-11-17 06:29:27 PST 
The test failure is introduced by r72040 and fixed in <http://trac.webkit.org/changeset/72135>