User can set ZoomTextOnly in the QWebSetting, however, qwebframe doesn't check the ZoomTextOnly attribute when applying the zoom...
Created attachment 73938 [details] first try
Comment on attachment 73938 [details] first try Nice catch! r=me
(In reply to comment #2) > (From update of attachment 73938 [details]) > Nice catch! r=me Thanks for quick review, kling :)
Comment on attachment 73938 [details] first try Clearing flags on attachment: 73938 Committed r72055: <http://trac.webkit.org/changeset/72055>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/72055 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/block/float/015.html
And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ... Guys, could you watch the bots next time after commit?
(In reply to comment #7) > And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ... > Guys, could you watch the bots next time after commit? oops, Sorry, I will look at the tests failed issue ASAP.
(In reply to comment #7) > And a follow-up patch landed in: http://trac.webkit.org/changeset/72069 ... > Guys, could you watch the bots next time after commit? Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch.
(In reply to comment #9) > Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch. I meant minor pixel differences caused by your patch and not this flakey test.
(In reply to comment #10) > (In reply to comment #9) > > Checked the ChangeLog, and found Dan has disabled this test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579. I don't think this test is caused by this patch. > > I meant minor pixel differences caused by your patch and not this flakey test. I rolled back my changes but still see this test failed... hmmm, need take more time to look at it.
The test failure is introduced by r72040 and fixed in <http://trac.webkit.org/changeset/72135>