Bug 49579 - REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree
Summary: REGRESSION (r72040): Error image with alt text can cause style to be frozen i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nobody
URL:
Keywords: HasReduction, LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2010-11-15 23:09 PST by mitz
Modified: 2010-11-16 14:09 PST (History)
3 users (show)

See Also:


Attachments
Test case (657 bytes, text/html)
2010-11-15 23:09 PST, mitz
no flags Details
Only defer intrinsic size compoutation if a style recalc is coming (8.45 KB, patch)
2010-11-16 13:11 PST, mitz
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2010-11-15 23:09:13 PST
Created attachment 73964 [details]
Test case

See attached test case. The problem is that RenderImage::imageChanged() is called during attach() when an ancestor is attaching during recalcStyle(), and imageChanged() calls setNeedsStyleRecalc(). After recalcStyle() calls attach, it clears the childNeedsStyleRecalc state for itself, but not for all of its descendants leading down to the image. Now there is an island out of which setNeedsStyleRecalc() cannot propagate to the root.
Comment 1 mitz 2010-11-15 23:11:47 PST
<rdar://problem/8672000>
Comment 2 mitz 2010-11-15 23:17:38 PST
This bug was causing fast/block/float/015.html to fail intermittently, so I disabled it in <http://trac.webkit.org/projects/webkit/changeset/72064>.
Comment 3 mitz 2010-11-16 13:11:10 PST
Created attachment 74030 [details]
Only defer intrinsic size compoutation if a style recalc is coming
Comment 4 Simon Fraser (smfr) 2010-11-16 13:49:55 PST
Comment on attachment 74030 [details]
Only defer intrinsic size compoutation if a style recalc is coming

View in context: https://bugs.webkit.org/attachment.cgi?id=74030&action=review

> WebCore/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=49579
> +
> +        Tests: fast/block/float/015.html

I'd like to see some words here about what the problem was. I don't think the but title is quite enough.
Comment 5 mitz 2010-11-16 14:09:09 PST
Fixed in <http://trac.webkit.org/changeset/72135>.