Bug 49446 - check-webkit-style function detection doesn't detect indented functions declaractions.
Summary: check-webkit-style function detection doesn't detect indented functions decla...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 49394
  Show dependency treegraph
 
Reported: 2010-11-12 07:58 PST by David Levin
Modified: 2010-11-13 20:11 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.22 KB, patch)
2010-11-12 08:01 PST, David Levin
no flags Details | Formatted Diff | Diff
Patch (5.22 KB, patch)
2010-11-12 08:04 PST, David Levin
no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2010-11-12 09:36 PST, David Levin
hamaji: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-11-12 07:58:53 PST
See summary.
Comment 1 David Levin 2010-11-12 08:01:11 PST
Created attachment 73744 [details]
Patch
Comment 2 David Levin 2010-11-12 08:04:10 PST
Created attachment 73746 [details]
Patch
Comment 3 David Levin 2010-11-12 08:07:45 PST
Comment on attachment 73746 [details]
Patch

Whoops, I meant cq? not cq+.
Comment 4 WebKit Commit Bot 2010-11-12 08:24:38 PST
Comment on attachment 73746 [details]
Patch

Rejecting patch 73746 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
tTools/Scripts/webkitpy/style/checkers/cpp.py", line 1211, in check_for_function_lengths
    ending_line_number = close_expression(clean_lines, start_line_number, open_brace_index)[1]
  File "/Users/abarth/git/webkit-queue/WebKitTools/Scripts/webkitpy/style/checkers/cpp.py", line 643, in close_expression
    line = clean_lines.elided[line_number]
IndexError: list index out of range

----------------------------------------------------------------------
Ran 692 tests in 8.902s

FAILED (errors=8)

Full output: http://queues.webkit.org/results/5753022
Comment 5 David Levin 2010-11-12 09:11:54 PST
Comment on attachment 73746 [details]
Patch

Tests don't pass.
Comment 6 David Levin 2010-11-12 09:36:14 PST
Created attachment 73752 [details]
Patch
Comment 7 Shinichiro Hamaji 2010-11-13 02:15:45 PST
Comment on attachment 73752 [details]
Patch

Looks good.
Comment 8 WebKit Commit Bot 2010-11-13 19:26:25 PST
Comment on attachment 73752 [details]
Patch

Rejecting patch 73752 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73752]" exit_code: 2
Last 500 characters of output:
succeeded at 612 (offset 1 line).
Hunk #3 succeeded at 622 (offset 1 line).
Hunk #4 succeeded at 639 (offset 1 line).
Hunk #5 succeeded at 1174 (offset 1 line).
Hunk #6 FAILED at 1210.
1 out of 6 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/checkers/cpp.py.rej
patching file WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Shinichiro Hamaji', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6020030
Comment 9 David Levin 2010-11-13 20:11:42 PST
Committed as http://trac.webkit.org/changeset/71976