Bug 49394 - check-webkit-style should check for meaningless variable names in function declarations.
Summary: check-webkit-style should check for meaningless variable names in function de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on: 49425 49427 49446 51303 51451 51523
Blocks:
  Show dependency tree / graph
 
Reported: 2010-11-11 11:34 PST by David Levin
Modified: 2010-12-27 11:08 PST (History)
0 users

See Also:

Attachments
Work in progress. (It is being subdivided, cleaned up, and finished as smaller patches.) (8.29 KB, patch)
2010-11-12 05:41 PST, David Levin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-11-11 11:34:00 PST 
This is the style rule:
  Leave meaningless variable names out of function declarations.
  Right:
  void setCount(size_t);
  Wrong:
  void setCount(size_t count);

from http://webkit.org/coding/coding-style.html
Comment 1 David Levin 2010-11-12 05:41:38 PST 
Created attachment 73730 [details]
Work in progress. (It is being subdivided, cleaned up, and finished as smaller patches.)
Comment 2 David Levin 2010-12-27 11:08:37 PST 
Comment on attachment 73730 [details]
Work in progress. (It is being subdivided, cleaned up, and finished as smaller patches.)

Cleaned up. Made into smaller patches. Etc.

All done!