You need to
before you can comment on or make changes to this bug.
Due to font size differences between the ports, we need something other than text to determine the size of divs and iframes in Spatial Navigation tests.
I am about to submit a patch with a simple image, it will be used in future patches for the tests.
It looks like a duplicated bug.
Please see bug 47448, bug 47449 and 43030
Created an attachment (id=73642) [details]
(In reply to comment #1)
> It looks like a duplicated bug.
> Please see bug 47448, bug 47449 and 43030
There is a good chance that you are right.
Once we have the image committed, I will change the tests to use it and see if it solves the other bugs. (If yes, then the patch at https://bugs.webkit.org/show_bug.cgi?id=49382 can become much smaller).
https://bugs.webkit.org/show_bug.cgi?id=47449 does not seem related to this.
Pressing the end key should take you to the bottom of the page regardless of the size of that page.
https://bugs.webkit.org/show_bug.cgi?id=47448 might be related, need to investigate more.
https://bugs.webkit.org/show_bug.cgi?id=43030 should be fixed once we switch the multiple <br> into a fixed size image.
(From update of attachment 73642 [details])
Yael, I understand your logic, and I like it.
Please provide the patch that changes the tests together with this image. There is no reason to commit this png alone.
(In reply to comment #5)
> (From update of attachment 73642 [details] [details])
> Yael, I understand your logic, and I like it.
> Please provide the patch that changes the tests together with this image. There is no reason to commit this png alone.
Thanks for the review Antonio. From analysis I did last night, the only existing bug that I can fix by replacing the test content with an image is https://bugs.webkit.org/show_bug.cgi?id=43030.
I will fix that and re-submit.
Created an attachment (id=73732) [details]
This patch adds the green image and also modifies fast/events/spatial-navigation/snav-clipped-overflowed-content.html to use it.
I am still building for gtk and mac, and will set review flag once I verify that it works on those platforms.
Created an attachment (id=73742) [details]
Tested on qt, gtk and mac. They all pass with this updated test.
*** Bug 43030 has been marked as a duplicate of this bug. ***
(From update of attachment 73742 [details])
Clearing flags on attachment: 73742
Committed r71915: <http://trac.webkit.org/changeset/71915>
All reviewed patches have been landed. Closing bug.
Revision r71915 cherry-picked into qtwebkit-2.1 with commit 655d83e <http://gitorious.org/webkit/qtwebkit/commit/655d83e>