SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations

[Dirk Schulze]

SVG animations should use from-to-by animations as some kind of fallback, if a values list is not specified. The specification goes a bit more into detail about spline but it's still necessary to investigate what other viewers are doing. See last two paragraphs in http://www.w3.org/TR/SMIL3/smil-animation.html#animationNS-InterpolationKeysplines

[Dirk Schulze]

Created attachment 73424 [details]
calcMode="spline" from-to-animation

[Dirk Schulze]

Created attachment 73607 [details]
Patch

[Nikolas Zimmermann]

Comment on attachment 73607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73607&action=review

Tests look great, please change bug title and clarify changelog, r=me.

> WebCore/ChangeLog:5
> +        SVGAnimation calcMode="spline" should use 'to' 'by' animation if no values were specified

The bug title is unclear, wheter you mean 'to-by' animation or 'to or by animation'.

> WebCore/ChangeLog:8
> +        Add support for from-to-by animations in combination with calcMode 'spline' for SVGAnimations.

from-to-by?
you mean from-to / from-by ?

> WebCore/svg/SVGAnimationElement.cpp:515
>          unsigned num = m_keySplines.size() + 1;

s/num/splinesCount/  ?

[Dirk Schulze]

Committed r71828: <http://trac.webkit.org/changeset/71828>

[Dirk Schulze]

Committed r71830: <http://trac.webkit.org/changeset/71830>

[WebKit Review Bot]

http://trac.webkit.org/changeset/71828 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
media/video-played-collapse.html
media/video-played-ranges-1.html
media/video-played-reset.html

[WebKit Review Bot]

http://trac.webkit.org/changeset/71830 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
media/video-played-collapse.html
media/video-played-ranges-1.html
media/video-played-reset.html