Bug 49230 – Philip Canvas test 2d.pattern.image.incomplete fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Helder Correia]

The test should be modified in the same way as 2d.drawImage.incomplete.  See https://bugs.webkit.org/show_bug.cgi?id=48306.

[Helder Correia]

Created attachment 73327 [details]
Patch

[Andreas Kling]

Comment on attachment 73327 [details]
Patch

LGTM.

[WebKit Commit Bot]

Comment on attachment 73327 [details]
Patch

Rejecting patch 73327 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
.................................................
canvas/philip/tests/2d.pattern.image.incomplete.html -> failed

Exiting early after 1 failures. 653 tests run.
21.28s total testing time

652 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
2 test cases (<1%) had stderr output

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd']" exit_code: 1

2 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/5445048

[Helder Correia]

(In reply to comment #3)
> (From update of attachment 73327 [details])
> Rejecting patch 73327 from commit-queue.

Any idea why the test failed? It passes just fine on my machine.

[Helder Correia]

(In reply to comment #4)
> Any idea why the test failed? It passes just fine on my machine.

My bad, I need to change 2d.pattern.image.incomplete-expected.txt.

[Helder Correia]

Created attachment 73431 [details]
Patch

[Matthew Delaney]

There's no need to leave the snow-leopard expected results file. You can blow that file away and then run-webkit-tests will compare the results against the top-level expected results file (that should be passing as well).

Also, if you cc some of the other ports' canvas-concerned people on these sorts of bugs then they'll be aware that these tests may now be passing on their ports and thus they can unskip the tests (assuming they've skipped them).

[Helder Correia]

Created attachment 73444 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 73444 [details]
Patch

Clearing flags on attachment: 73444

Committed r71718: <http://trac.webkit.org/changeset/71718>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.