Bug 48306 - Fix LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.html
Summary: Fix LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.html
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matthew Delaney
Depends on:
Blocks: 46506
  Show dependency treegraph
Reported: 2010-10-25 22:53 PDT by Mike Lawther
Modified: 2010-11-03 18:20 PDT (History)
3 users (show)

See Also:

Patch (3.97 KB, patch)
2010-11-03 17:51 PDT, Matthew Delaney
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2010-10-25 22:53:13 PDT
This layout test fails. See master bug: https://bugs.webkit.org/show_bug.cgi?id=46506
Comment 1 Matthew Delaney 2010-11-03 16:58:41 PDT
I believe this test is incorrect in the way that it creates an image that is supposed to have its complete attribute set to false. Per the spec, an <img> without a src attribute specified should have complete return true:

The IDL attribute complete must return true if any of the following conditions is true:

The src attribute is omitted.
The src attribute's value is the empty string.
The final task that is queued by the networking task source once the resource has been fetched has been queued, but has not yet been run, and the img element is not in the broken state.
The img element is completely available.
from http://dev.w3.org/html5/spec/Overview.html#dom-img-complete

I'm going to modify the test to create the image and then set its src attribute to be a non-existent file. This will cause the image to have complete=false.
Comment 2 Matthew Delaney 2010-11-03 17:51:28 PDT
Created attachment 72890 [details]
Comment 3 Darin Adler 2010-11-03 17:55:01 PDT
Comment on attachment 72890 [details]

How are we getting these test changes back to the original tests?
Comment 4 Matthew Delaney 2010-11-03 18:02:51 PDT
By cc-ing philip! :-) I've been chatting with him off and on via IRC about these issues. He said he's quite busy but always wants to be CC-ed or informed about them so that we can incorporate them later. 

There's also an effort to get his most up-to-date versions of his tests since some of the ones we have are out of date. Though, as I run through individual tests, I'm making sure to sync up the tests that I post fixes for - hopefully that'll make syncing up with his new test versions easier.
Comment 5 Matthew Delaney 2010-11-03 18:20:15 PDT
Committed r71292: <http://trac.webkit.org/changeset/71292>