Bug 48894 - Fix canvas/philip/tests/2d.pattern.image.undefined.html
Summary: Fix canvas/philip/tests/2d.pattern.image.undefined.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks: 46506
  Show dependency treegraph
 
Reported: 2010-11-02 18:58 PDT by Matthew Delaney
Modified: 2010-11-03 19:00 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.31 KB, patch)
2010-11-03 00:55 PDT, Matthew Delaney
no flags Details | Formatted Diff | Diff
Patch (7.24 KB, patch)
2010-11-03 10:49 PDT, Matthew Delaney
no flags Details | Formatted Diff | Diff
Patch (6.57 KB, patch)
2010-11-03 11:42 PDT, Matthew Delaney
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2010-11-02 18:58:41 PDT
Another test where we're just not throwing the right error code.
Comment 1 Matthew Delaney 2010-11-03 00:55:57 PDT
Created attachment 72794 [details]
Patch
Comment 2 Andreas Kling 2010-11-03 01:35:28 PDT
Comment on attachment 72794 [details]
Patch

You should remove the test from the skiplists in this patch (currently skipped on gtk, mac-leopard and qt.)

Also, this is basically a dup of bug 37177.
Comment 3 Matthew Delaney 2010-11-03 10:49:11 PDT
Created attachment 72840 [details]
Patch
Comment 4 Darin Adler 2010-11-03 11:15:11 PDT
Comment on attachment 72840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72840&action=review

The test cases cover passing non-objects, but not passing objects of the wrong type, which follows a different code path. I’d like to see tests covering all the code changes?

What about drawImageFromRect?

> WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:272
> -    } else
> -       return throwTypeError(exec);
> -    
> +    }
> +    setDOMException(exec, TYPE_MISMATCH_ERR);

This change looks wrong. It seems we will set the exception in cases where we succeeded above. After those cases break out of their switch statements and then fall out of the if statements.

Do we have test cases covering those? Are they failing with exceptions now? If not, why not?
Comment 5 Matthew Delaney 2010-11-03 11:23:38 PDT
Sorry about that, I muddled together two patches. The correct split up patches are coming now.
Comment 6 Matthew Delaney 2010-11-03 11:42:20 PDT
Created attachment 72846 [details]
Patch
Comment 7 Matthew Delaney 2010-11-03 14:23:19 PDT
Committed r71268: <http://trac.webkit.org/changeset/71268>
Comment 8 WebKit Review Bot 2010-11-03 14:43:49 PDT
http://trac.webkit.org/changeset/71268 might have broken Qt Linux Release
The following tests are not passing:
svg/in-html/by-reference.html
svg/in-html/circle.html
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
svg/text/foreignObject-text-clipping-bug.xml
svg/text/selection-background-color.xhtml
svg/text/selection-styles.xhtml
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/page/zoom-hixie-mixed-008.xml
svg/zoom/page/zoom-hixie-mixed-009.xml
svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
svg/zoom/page/zoom-svg-float-border-padding.xml
Comment 9 Csaba Osztrogonác 2010-11-03 19:00:27 PDT
(In reply to comment #8)
> http://trac.webkit.org/changeset/71268 might have broken Qt Linux Release
> The following tests are not passing:
> svg/in-html/by-reference.html
> svg/in-html/circle.html
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
> svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
> svg/text/foreignObject-text-clipping-bug.xml
> svg/text/selection-background-color.xhtml
> svg/text/selection-styles.xhtml
> svg/zoom/page/zoom-coords-viewattr-01-b.svg
> svg/zoom/page/zoom-hixie-mixed-008.xml
> svg/zoom/page/zoom-hixie-mixed-009.xml
> svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
> svg/zoom/page/zoom-svg-float-border-padding.xml

Sorry for SPAM. 

New bug report filed: https://bugs.webkit.org/show_bug.cgi?id=48958