Bug 48958 - [Qt] DRT sideeffect revealed by r71268
Summary: [Qt] DRT sideeffect revealed by r71268
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: Qt, QtTriaged
Depends on:
Reported: 2010-11-03 15:23 PDT by Csaba Osztrogonác
Modified: 2011-05-02 07:27 PDT (History)
3 users (show)

See Also:

proposed fix (3.26 KB, patch)
2011-05-02 06:01 PDT, Fehér Zsolt
no flags Details | Formatted Diff | Diff
proposed fix (3.26 KB, patch)
2011-05-02 06:11 PDT, Fehér Zsolt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-11-03 15:23:23 PDT
After r71268, 15 tests fail on Qt bot: 

r71268 fixed an absolutely unrelated bug, and unskipped two tests:

old-run-webkit-test script restarts DRT after 1000 tests, and 
this patch shifted the restart point, and the bug was revealed.
Comment 1 Csaba Osztrogonác 2010-11-03 15:50:58 PDT
I added the unskipped tests to the Skipped list again, to make builbot happy:


Tomorrow I'm going to find a real fix for this bug.
Comment 2 Csaba Osztrogonác 2010-11-03 18:45:39 PDT
Unfortunately 3 new tests added in http://trac.webkit.org/changeset/71277 ,
and the 15 tests fail again.

I found the real culprit: svg/custom/text-zoom.xhtml ,
and skipped it by http://trac.webkit.org/changeset/71295
Comment 3 Fehér Zsolt 2011-05-02 06:01:52 PDT
Created attachment 91917 [details]
proposed fix
Comment 4 WebKit Review Bot 2011-05-02 06:04:39 PDT
Attachment 91917 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:557:  Should have a space between // and comment  [whitespace/comments] [4]
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:558:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Fehér Zsolt 2011-05-02 06:11:00 PDT
Created attachment 91920 [details]
proposed fix
Comment 6 Csaba Osztrogonác 2011-05-02 07:07:49 PDT
Comment on attachment 91920 [details]
proposed fix

Comment 7 WebKit Commit Bot 2011-05-02 07:27:41 PDT
Comment on attachment 91920 [details]
proposed fix

Clearing flags on attachment: 91920

Committed r85474: <http://trac.webkit.org/changeset/85474>
Comment 8 WebKit Commit Bot 2011-05-02 07:27:46 PDT
All reviewed patches have been landed.  Closing bug.