I tried building Chromium with clang, according to the instructions posted at http://code.google.com/p/chromium/wiki/Clang The build failed because of the following compiler warning-turned-error: DumpRenderTree/chromium/TestShell.h:147:68: error: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] This was introduced in changeset 70537: http://trac.webkit.org/changeset/70537
Created attachment 72708 [details] Fix Here is the fix. Since gcc doesn't issue this warning by default, would it not be worth adding -Wtype-limits (and possibly others) to all CFLAGS, to ensure a smoother gcc <-> clang transition in the future?
Comment on attachment 72708 [details] Fix ok.
Created attachment 72723 [details] Fix (fixed) Oops, I accidentally made changes in the wrong git branch, and my previous patch turned out backwards. Here is the correct fix.
Comment on attachment 72723 [details] Fix (fixed) ok.
Isn't this what is already fixed by https://bugs.webkit.org/show_bug.cgi?id=48414?
(In reply to comment #5) > Isn't this what is already fixed by https://bugs.webkit.org/show_bug.cgi?id=48414? Oh, yeah, it is... I had a 1-day-old copy of WebKit that I should have refreshed...
Comment on attachment 72723 [details] Fix (fixed) Setting cq-. This was already fixed yesterday in bug 48414, and I haven't noticed.
*** This bug has been marked as a duplicate of bug 48414 ***