We want to move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk, which an important step in moving away from the Mozilla theme drawing code and fixing menu list rendering.
Created attachment 72125 [details] Patch for this issue
Attachment 72125 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/gtk/RenderThemeGtk.cpp:473: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > If any of these errors are false positives, please file a bug against check-webkit-style. This is a false positive. We need to add an exception for gtk_widget_style_get.
Attachment 72125 [details] did not build on gtk: Build output: http://queues.webkit.org/results/4748081
Created attachment 72789 [details] Patch with slightly different design
Attachment 72789 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/gtk/RenderThemeGtk.cpp']" exit_code: 1 WebCore/platform/gtk/RenderThemeGtk.cpp:473: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 72789 [details] did not build on gtk: Build output: http://queues.webkit.org/results/5164016
Comment on attachment 72789 [details] Patch with slightly different design This one looks right to me, now I'll review the one it depends on (doh).
Attachment 72789 [details] was posted by a committer and has review+, assigning to Martin Robinson for commit.
r74132. Please close your bugs after landing. :)
Comment on attachment 72789 [details] Patch with slightly different design Sorry. Will try to be better about this in the future.