Bug 47836 – [GTK] Move input type=range rendering to RenderThemeGtk

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

This will be the first in a series of patches which move support for rendering widgets out of gtk2drawing.c and into RenderThemeGtk.

[Martin Robinson]

Created attachment 71059 [details]
Patch for this issue

[Martin Robinson]

Created attachment 72116 [details]
Patch fixing several issues and updated to ToT

[Gustavo Noronha (kov)]

Comment on attachment 72116 [details]
Patch fixing several issues and updated to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=72116&action=review

> WebCore/platform/gtk/RenderThemeGtk.cpp:548
> +        shrink.setWidth(gtk_widget_get_style(widget)->ythickness);

Looks like we want xthickness here.

> WebCore/platform/gtk/RenderThemeGtk.cpp:618
> +        GtkWidget* widget = part == SliderThumbHorizontalPart ? gtkHScale() : gtkVScale();
> +        int length = 0, width = 0;
> +        gtk_widget_style_get(widget,
> +                             "slider_length", &length,
> +                             "slider_width", &width,
> +                             NULL);
> +        o->style()->setWidth(Length(length, Fixed));
> +        o->style()->setHeight(Length(width, Fixed));

This is very unintuitive. Is really height? Is it always height, or just when it's an horizontal slider? Looking at GTK+'s code, it looks like width is height when horizontal and width for real when vertical, and WebCore's style seems to be saner, and always treat width as width, so I think this is wrong.

r=me with those two fixed =)

[Eric Seidel (no email)]

Attachment 72116 [details] was posted by a committer and has review+, assigning to Martin Robinson for commit.

[Martin Robinson]

Committed r74129: <http://trac.webkit.org/changeset/74129>