Bug 48223 - [Qt] Update the baseline for blur shadow test
Summary: [Qt] Update the baseline for blur shadow test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Ariya Hidayat
URL:
Keywords: HTML5, Qt, QtTriaged
Depends on:
Blocks: 34479 46327
  Show dependency tree / graph
 
Reported: 2010-10-25 00:26 PDT by Ariya Hidayat
Modified: 2010-11-07 18:50 PST (History)
3 users (show)

See Also:

Attachments
Patch (53.58 KB, patch)
2010-10-25 00:50 PDT, Ariya Hidayat 		no flags Details | Formatted Diff | Diff
Correct box-shadow behavior when using blur and border-radius. (52.70 KB, patch)
2010-11-04 22:35 PDT, Helder Correia 		ariya.hidayat: review-
Details | Formatted Diff | Diff
Correct basic-shadows line segments. (50.63 KB, patch)
2010-11-05 13:20 PDT, Helder Correia 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-10-25 00:26:04 PDT 
After the blur radius fix in r68145, blur shadow test needs a new baseline.
Comment 1 Ariya Hidayat 2010-10-25 00:50:02 PDT 
Created attachment 71720 [details]
Patch
Comment 2 Ariya Hidayat 2010-10-25 03:09:20 PDT 
Comment on attachment 71720 [details]
Patch

Clearing flags on attachment: 71720

Committed r70447: <http://trac.webkit.org/changeset/70447>
Comment 3 Ariya Hidayat 2010-10-25 03:09:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Helder Correia 2010-11-04 22:35:28 PDT 
Created attachment 73037 [details]
Correct box-shadow behavior when using blur and border-radius.

Updated blur rounded corner box shadow.
Comment 5 Ariya Hidayat 2010-11-05 09:08:12 PDT 
Comment on attachment 73037 [details]
Correct box-shadow behavior when using blur and border-radius.

LGTM.
Comment 6 Ariya Hidayat 2010-11-05 12:34:55 PDT 
Comment on attachment 73037 [details]
Correct box-shadow behavior when using blur and border-radius.

r- because it includes a fix which is not landed yet.
Comment 7 Helder Correia 2010-11-05 13:20:20 PDT 
Created attachment 73106 [details]
Correct basic-shadows line segments.

Updated basic-shadows expected PNG
Comment 8 Ariya Hidayat 2010-11-05 18:40:20 PDT 
Comment on attachment 73106 [details]
Correct basic-shadows line segments.

LGTM.
Comment 9 Ariya Hidayat 2010-11-06 09:47:47 PDT 
reopening
Comment 10 Ariya Hidayat 2010-11-06 18:14:13 PDT 
Comment on attachment 73106 [details]
Correct basic-shadows line segments.

Remove from cq, seems the bot can't handle it.
Comment 11 Eric Seidel (no email) 2010-11-06 21:02:44 PDT 
I'm not sure what you mean by that?  Do we need a bug against the cq?
Comment 12 Andreas Kling 2010-11-07 17:49:56 PST 
Committed r71486: <http://trac.webkit.org/changeset/71486>
Comment 13 Ariya Hidayat 2010-11-07 17:53:01 PST 
> I'm not sure what you mean by that?  Do we need a bug against the cq?

The bot was doing the right thing. It could not land the patch because the tree was red (for SL?).