Bug 48183 - Add Gradient::hasAlpha
Summary: Add Gradient::hasAlpha
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 48180
  Show dependency tree / graph
 
Reported: 2010-10-23 05:59 PDT by Patrick R. Gansterer
Modified: 2010-10-23 08:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2010-10-23 06:03 PDT, Patrick R. Gansterer 		ddkilzer: review-
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Patch (1.81 KB, patch)
2010-10-23 07:11 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-10-23 05:59:44 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-10-23 06:03:23 PDT 
Created attachment 71637 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2010-10-23 07:00:37 PDT 
Comment on attachment 71637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71637&action=review

r- due to the for() loop style issue

> WebCore/platform/graphics/Gradient.cpp:203
> +    for (size_t i = 0; i < m_stops.size(); i++)
> +        if (m_stops[i].alpha < 1)
> +            return true;

The for loop must have curly braces around it because it's body is more than two lines.
Comment 3 Patrick R. Gansterer 2010-10-23 07:11:32 PDT 
Created attachment 71640 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2010-10-23 07:16:29 PDT 
Comment on attachment 71640 [details]
Patch

r=me  Thanks!
Comment 5 WebKit Commit Bot 2010-10-23 08:08:56 PDT 
Comment on attachment 71640 [details]
Patch

Clearing flags on attachment: 71640

Committed r70389: <http://trac.webkit.org/changeset/70389>
Comment 6 WebKit Commit Bot 2010-10-23 08:09:00 PDT 
All reviewed patches have been landed.  Closing bug.