Bug 48180 – [WINCE] Rename SharedBitmap::createInstance to SharedBitmap::create

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 71634 [details]
Patch

New new create function are:
PassRefPtr<SharedBitmap> SharedBitmap::create(const IntSize& size, BitmapInfo::BitCount bitCount, bool initPixels)
PassRefPtr<SharedBitmap> SharedBitmap::create(const Vector<unsigned>& data, const IntSize& size, bool hasAlpha)

[David Kilzer (:ddkilzer)]

Where are the SharedBitmap::create() methods defined?  I don't see SharedBitmap.h in the tree.  (Has it not been upstreamed yet?)

[Patrick R. Gansterer]

(In reply to comment #2)
> Where are the SharedBitmap::create() methods defined?  I don't see SharedBitmap.h in the tree.  (Has it not been upstreamed yet?)
It's not upstreamed yet and I want to upream it with the correct name of the create-function: see bug 28272 for SharedBitmap

[David Kilzer (:ddkilzer)]

Comment on attachment 71634 [details]
Patch

Thanks!  r=me

[WebKit Commit Bot]

Comment on attachment 71634 [details]
Patch

Rejecting patch 71634 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 71634]" exit_code: 2
Last 500 characters of output:
3 (offset -8 lines).
Hunk #3 succeeded at 1777 (offset -17 lines).
patching file WebCore/platform/graphics/wince/ImageBufferWinCE.cpp
Hunk #1 succeeded at 64 (offset -1 lines).
patching file WebCore/platform/graphics/wince/ImageWinCE.cpp
Hunk #1 FAILED at 43.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/graphics/wince/ImageWinCE.cpp.rej

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Kilzer', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4708040

[Patrick R. Gansterer]

Comment on attachment 71634 [details]
Patch

Clearing flags on attachment: 71634

Manually committed r70397: <http://trac.webkit.org/changeset/70397>

[Patrick R. Gansterer]

All reviewed patches have been landed.  Closing bug.