Bug 48180 - [WINCE] Rename SharedBitmap::createInstance to SharedBitmap::create
Summary: [WINCE] Rename SharedBitmap::createInstance to SharedBitmap::create
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
Depends on: 48183
  Show dependency treegraph
Reported: 2010-10-23 04:38 PDT by Patrick R. Gansterer
Modified: 2010-10-23 12:01 PDT (History)
3 users (show)

See Also:

Patch (4.37 KB, patch)
2010-10-23 04:45 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-10-23 04:38:49 PDT
see patch
Comment 1 Patrick R. Gansterer 2010-10-23 04:45:11 PDT
Created attachment 71634 [details]

New new create function are:
PassRefPtr<SharedBitmap> SharedBitmap::create(const IntSize& size, BitmapInfo::BitCount bitCount, bool initPixels)
PassRefPtr<SharedBitmap> SharedBitmap::create(const Vector<unsigned>& data, const IntSize& size, bool hasAlpha)
Comment 2 David Kilzer (:ddkilzer) 2010-10-23 07:25:46 PDT
Where are the SharedBitmap::create() methods defined?  I don't see SharedBitmap.h in the tree.  (Has it not been upstreamed yet?)
Comment 3 Patrick R. Gansterer 2010-10-23 09:24:43 PDT
(In reply to comment #2)
> Where are the SharedBitmap::create() methods defined?  I don't see SharedBitmap.h in the tree.  (Has it not been upstreamed yet?)
It's not upstreamed yet and I want to upream it with the correct name of the create-function: see bug 28272 for SharedBitmap
Comment 4 David Kilzer (:ddkilzer) 2010-10-23 10:41:53 PDT
Comment on attachment 71634 [details]

Thanks!  r=me
Comment 5 WebKit Commit Bot 2010-10-23 10:43:26 PDT
Comment on attachment 71634 [details]

Rejecting patch 71634 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 71634]" exit_code: 2
Last 500 characters of output:
3 (offset -8 lines).
Hunk #3 succeeded at 1777 (offset -17 lines).
patching file WebCore/platform/graphics/wince/ImageBufferWinCE.cpp
Hunk #1 succeeded at 64 (offset -1 lines).
patching file WebCore/platform/graphics/wince/ImageWinCE.cpp
Hunk #1 FAILED at 43.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/graphics/wince/ImageWinCE.cpp.rej

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Kilzer', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4708040
Comment 6 Patrick R. Gansterer 2010-10-23 12:01:20 PDT
Comment on attachment 71634 [details]

Clearing flags on attachment: 71634

Manually committed r70397: <http://trac.webkit.org/changeset/70397>
Comment 7 Patrick R. Gansterer 2010-10-23 12:01:35 PDT
All reviewed patches have been landed.  Closing bug.