NEW 48182
webkit-patch --suggest-reviewers should let you pick individuals 
https://bugs.webkit.org/show_bug.cgi?id=48182
Summary webkit-patch --suggest-reviewers should let you pick individuals
David Kilzer (:ddkilzer)
Reported 2010-10-23 05:33:44 PDT
The webkit-patch --suggest-reviewers switch is great, but when uploading a patch for Bug 48181, I only wanted to CC one of the three suggested reviewers (because he added the specific line of code that I was changing). It would be nice if you could pick and choose individuals suggested in the list instead of an all-or-none situation. For example, this is the current prompt: The following reviewers have recently modified files in your patch: Darin Fisher David Levin Jian Li Would you like to CC them? [Y/n]: A more flexible prompt would be: The following reviewers have recently modified files in your patch: [1] Darin Fisher [2] David Levin [3] Jian Li Would you like to CC them? [A]ll/[N]one/list: A list of numbers should allow for spaces and/or commas as separators (e.g., match separators on /[ ,]+/).
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-10-23 10:38:53 PDT
Agreed. Adam wanted this too. We definitely need a bunch of iteration on --suggest-reviewers.
Note You need to log in before you can comment on or make changes to this bug.