Bug 48181 – Add missing include of MacErrors.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

Add missing include of MacErrors.h

[David Kilzer (:ddkilzer)]

Created attachment 71635 [details]
Patch v1

[WebKit Commit Bot]

Comment on attachment 71635 [details]
Patch v1

Rejecting patch 71635 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
N_MINOR 0320
    setenv YACC /Developer/usr/bin/yacc
    /bin/sh -c /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh

** BUILD FAILED **


The following build commands failed:
WebCore:
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FormDataStreamMac.o /Projects/CommitQueue/WebCore/platform/network/mac/FormDataStreamMac.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2
(1 failure)


Full output: http://queues.webkit.org/results/4675043

[David Kilzer (:ddkilzer)]

Comment on attachment 71635 [details]
Patch v1

Clearing flags.  Apparently fnfErr is defined elsewhere.

[David Kilzer (:ddkilzer)]

Created attachment 71647 [details]
Patch v2

[Alexey Proskuryakov]

Comment on attachment 71647 [details]
Patch v2

It took me some time to understand why Mac path also needed to be modified. Currently, Mac gets CoreServices through WebCorePrefix.h, and we want the code to build without it.

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> (From update of attachment 71647 [details])
> It took me some time to understand why Mac path also needed to be modified. Currently, Mac gets CoreServices through WebCorePrefix.h, and we want the code to build without it.

Thanks. Yes, MacErrors.h is part of CarbonCore.framework which is a sub-framework of CoreServices.framework.

[WebKit Commit Bot]

Comment on attachment 71647 [details]
Patch v2

Clearing flags on attachment: 71647

Committed r70399: <http://trac.webkit.org/changeset/70399>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.