Bug 48132 – Long lines in non-white-space-pre editable documents show cursor in wrong place

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Marijn Haverbeke]

See the link I provided, and follow the instructions.

Basically, Webkit refuses to show the cursor sitting past the right edge of the screen in an editable document that is, in principle, line-wrapping, but has a line that can't be wrapped and creates a horizontal scrollbar.

[Levi Weintraub]

Created attachment 73265 [details]
Using LogicalLayoutOverflow

This bug happen because RenderText::localCaretRect snaps the caret rect to its containing RenderBlock's logicalLeft and logicalRight when in autoWrap content. logicalLeft and Right don't take into account overflow, so the caret is clipped to the logical bounds.

[Levi Weintraub]

Created attachment 73308 [details]
Patch

[Darin Adler]

Comment on attachment 73308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73308&action=review

> LayoutTests/editing/selection/caret-painting-in-overflowing-autowrap-content.html:7
> +</body></html>
>  \ No newline at end of file

Normally we put a newline at the end of the file to avoid this.

[Levi Weintraub]

(In reply to comment #3)
> (From update of attachment 73308 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73308&action=review
> 
> > LayoutTests/editing/selection/caret-painting-in-overflowing-autowrap-content.html:7
> > +</body></html>
> >  \ No newline at end of file
> 
> Normally we put a newline at the end of the file to avoid this.

Thanks for the review! I'll fix that to avoid the problem.

[Levi Weintraub]

Landed in r76144

[WebKit Review Bot]

http://trac.webkit.org/changeset/76144 might have broken SnowLeopard Intel Release (Tests)

[Levi Weintraub]

Committed r76187: <http://trac.webkit.org/changeset/76187>

[Levi Weintraub]

(In reply to comment #7)
> Committed r76187: <http://trac.webkit.org/changeset/76187>

Fixed the expected results as they were initially incorrect.

[WebKit Review Bot]

http://trac.webkit.org/changeset/76187 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/forms/input-text-scroll-left-on-blur.html

[Dmitry Titov]

Rolled out in http://trac.webkit.org/changeset/76202

It broke fast/forms/input-text-scroll-left-on-blur.html on Snow Leopard bot: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/23925

Also, 4 existing tests failed (they all show caret in various forms) on all 3 platforms in Chromium:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/28
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/9
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/13

I could have rebaselined those without you, but I was not sure the behavior change is right.
Sorry for second rollout, it'd be better to add those other tests into test_expectations.txt and watch the effects of the relanded patch until dust settles.

[Levi Weintraub]

(In reply to comment #10)
> Rolled out in http://trac.webkit.org/changeset/76202
> 
> It broke fast/forms/input-text-scroll-left-on-blur.html on Snow Leopard bot: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/23925

Darn! Sorry to be such a thorn in your side on this one. I'll get to the bottom of it, thanks again!

[Levi Weintraub]

This was fixed in http://trac.webkit.org/changeset/84659 (from https://bugs.webkit.org/show_bug.cgi?id=49508)