RESOLVED INVALID 47977
Merge the Unicode backends of BrewMP and WinCE 
https://bugs.webkit.org/show_bug.cgi?id=47977
Summary Merge the Unicode backends of BrewMP and WinCE
Patrick R. Gansterer
Reported 2010-10-20 02:50:39 PDT
see bug 45716
Attachments
Patch (48.80 KB, patch)
2010-10-20 04:00 PDT, Patrick R. Gansterer 		eric: review+
paroga: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-10-20 04:00:48 PDT
Created attachment 71271 [details] Patch
Patrick R. Gansterer
Comment 2 2010-10-20 06:08:08 PDT
@kwangseo: can you give a short ok to this patch
Kwang Yul Seo
Comment 3 2010-10-20 07:59:11 PDT
ok
Patrick R. Gansterer
Comment 4 2010-10-22 09:50:37 PDT
Comment on attachment 71271 [details] Patch We should land manually to keep the svn history.
Eric Seidel (no email)
Comment 5 2010-12-10 22:14:31 PST
Comment on attachment 71271 [details] Patch Seems OK. The CQ should still track moves fine, but feel free to land this by hand. What makes MinimalICU minimal? Is it compiled with a --minimal option or something?
Patrick R. Gansterer
Comment 6 2010-12-11 02:32:07 PST
(In reply to comment #5) > (From update of attachment 71271 [details]) > Seems OK. The CQ should still track moves fine, but feel free to land this by hand. > > What makes MinimalICU minimal? Is it compiled with a --minimal option or something? It's only "minimal" copy of ICU stuff which is required for webkit. AFAIK there is no --minimal option. Maybe you have a better name for it? I also want to unify WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp and WebCore/platform/text/brew/TextBreakIteratorBrew.cpp and give it a better name. Maybe this name can match the "unicode backend name".
Eric Seidel (no email)
Comment 7 2010-12-20 22:45:58 PST
I'm confused as to why icu/ has anything more than the "required bits for webkit". How is your new minimal icu different?
Patrick R. Gansterer
Comment 8 2012-04-09 02:55:03 PDT
Code for BREW MP has been removed in r95934.
Eric Seidel (no email)
Comment 9 2012-07-27 14:15:15 PDT
Brew is dead and gone...
Eric Seidel (no email)
Comment 10 2012-07-27 14:15:32 PDT
nm. redundant comment.
Note You need to log in before you can comment on or make changes to this bug.