Bug 47977 - Merge the Unicode backends of BrewMP and WinCE
Summary: Merge the Unicode backends of BrewMP and WinCE
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 92539
  Show dependency tree / graph
 
Reported: 2010-10-20 02:50 PDT by Patrick R. Gansterer
Modified: 2012-07-27 14:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (48.80 KB, patch)
2010-10-20 04:00 PDT, Patrick R. Gansterer 		eric: review+
paroga: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-10-20 02:50:39 PDT 
see bug 45716
Comment 1 Patrick R. Gansterer 2010-10-20 04:00:48 PDT 
Created attachment 71271 [details]
Patch
Comment 2 Patrick R. Gansterer 2010-10-20 06:08:08 PDT 
@kwangseo: can you give a short ok to this patch
Comment 3 Kwang Yul Seo 2010-10-20 07:59:11 PDT 
ok
Comment 4 Patrick R. Gansterer 2010-10-22 09:50:37 PDT 
Comment on attachment 71271 [details]
Patch

We should land manually to keep the svn history.
Comment 5 Eric Seidel (no email) 2010-12-10 22:14:31 PST 
Comment on attachment 71271 [details]
Patch

Seems OK.  The CQ should still track moves fine, but feel free to land this by hand.

What makes MinimalICU minimal?  Is it compiled with a --minimal option or something?
Comment 6 Patrick R. Gansterer 2010-12-11 02:32:07 PST 
(In reply to comment #5)
> (From update of attachment 71271 [details])
> Seems OK.  The CQ should still track moves fine, but feel free to land this by hand.
> 
> What makes MinimalICU minimal?  Is it compiled with a --minimal option or something?
It's only "minimal" copy of ICU stuff which is required for webkit. AFAIK there is no --minimal option.
Maybe you have a better name for it?

I also want to unify WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp and WebCore/platform/text/brew/TextBreakIteratorBrew.cpp and give it a better name. Maybe this name can match the "unicode backend name".
Comment 7 Eric Seidel (no email) 2010-12-20 22:45:58 PST 
I'm confused as to why icu/ has anything more than the "required bits for webkit".  How is your new minimal icu different?
Comment 8 Patrick R. Gansterer 2012-04-09 02:55:03 PDT 
Code for BREW MP has been removed in r95934.
Comment 9 Eric Seidel (no email) 2012-07-27 14:15:15 PDT 
Brew is dead and gone...
Comment 10 Eric Seidel (no email) 2012-07-27 14:15:32 PDT 
nm. redundant comment.