Bug 92539 - Replace UnicodeWinCE with UnicodeWchar
Summary: Replace UnicodeWinCE with UnicodeWchar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 47977
Blocks: 108094
  Show dependency tree / graph
 
Reported: 2012-07-27 12:53 PDT by Patrick R. Gansterer
Modified: 2013-01-28 11:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (30.11 KB, patch)
2012-07-27 13:04 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (30.13 KB, patch)
2012-07-27 13:18 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (30.15 KB, patch)
2012-07-27 13:44 PDT, Patrick R. Gansterer 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (30.84 KB, patch)
2012-07-27 15:26 PDT, Patrick R. Gansterer 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-07-27 12:53:17 PDT 
Replace UnicodeWinCE with UnicodeWchar
Comment 1 Patrick R. Gansterer 2012-07-27 13:04:12 PDT 
Created attachment 155032 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-27 13:13:04 PDT 
Attachment 155032 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WTF/ChangeLog', u'Sou..." exit_code: 1
Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp:25:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Patrick R. Gansterer 2012-07-27 13:18:24 PDT 
Created attachment 155037 [details]
Patch
Comment 4 Patrick R. Gansterer 2012-07-27 13:44:28 PDT 
Created attachment 155040 [details]
Patch
Comment 5 WebKit Review Bot 2012-07-27 15:19:22 PDT 
Comment on attachment 155040 [details]
Patch

Attachment 155040 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13377642
Comment 6 Patrick R. Gansterer 2012-07-27 15:26:53 PDT 
Created attachment 155066 [details]
Patch
Comment 7 Ryosuke Niwa 2012-07-27 15:34:42 PDT 
Comment on attachment 155066 [details]
Patch

rs=me.
Comment 8 Patrick R. Gansterer 2012-07-30 03:30:08 PDT 
Committed r124010: <http://trac.webkit.org/changeset/124010>