Bug 47939 - Coalesce plug-in drawing
Summary: Coalesce plug-in drawing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-19 15:37 PDT by Anders Carlsson
Modified: 2010-10-25 10:42 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.30 KB, patch)
2010-10-19 15:42 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-10-19 15:37:05 PDT
Coalesce plug-in drawing
Comment 1 Anders Carlsson 2010-10-19 15:42:39 PDT
Created attachment 71213 [details]
Patch
Comment 2 Sam Weinig 2010-10-19 15:45:02 PDT
Comment on attachment 71213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71213&action=review

> WebKit2/PluginProcess/PluginControllerProxy.messages.in:62
> +    # Sent when the update requested by Update has been painted

Period at the end please.

> WebKit2/WebKit2Prefix.h:59
> -#define ENABLE_WEB_PROCESS_SANDBOX 1
> +#define ENABLE_WEB_PROCESS_SANDBOX 0

Please don't check this in.
Comment 3 Anders Carlsson 2010-10-19 15:48:43 PDT
Committed r70098: <http://trac.webkit.org/changeset/70098>
Comment 4 Simon Fraser (smfr) 2010-10-24 12:24:04 PDT
https://bugs.webkit.org/show_bug.cgi?id=47369#c10 says that this broke YouTube videos.
Comment 5 Anders Carlsson 2010-10-25 10:42:29 PDT
(In reply to comment #4)
> https://bugs.webkit.org/show_bug.cgi?id=47369#c10 says that this broke YouTube videos.

There's no way this broke YouTube videos, this code is in WebKit2 and ifdeffed out :)