Bug 47855 - Deploy Queue class in more places throughout QueueStatusServer
Summary: Deploy Queue class in more places throughout QueueStatusServer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 47847
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-18 15:42 PDT by Eric Seidel (no email)
Modified: 2010-10-18 20:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.79 KB, patch)
2010-10-18 15:44 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (14.80 KB, patch)
2010-10-18 16:06 PDT, Eric Seidel (no email)
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-18 15:42:40 PDT
Deploy Queue class in more places throughout QueueStatusServer
Comment 1 Eric Seidel (no email) 2010-10-18 15:44:57 PDT
Created attachment 71095 [details]
Patch
Comment 2 Adam Barth 2010-10-18 15:55:08 PDT
Comment on attachment 71095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71095&action=review

> WebKitTools/QueueStatusServer/model/workitems.py:39
> +    def position_for_attachment(self, attachment_id):

index_of_attachment
Comment 3 Eric Seidel (no email) 2010-10-18 16:06:28 PDT
Created attachment 71097 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-10-18 16:10:53 PDT
Comment on attachment 71097 [details]
Patch for landing

Rejecting patch 71097 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71097]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=71097&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47855&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 71097 from bug 47855.
Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4446076
Comment 5 Eric Seidel (no email) 2010-10-18 17:16:51 PDT
Comment on attachment 71097 [details]
Patch for landing

I forget that we have a cluster of commit-queues now and I can't post dependent patches as easily.
Comment 6 WebKit Commit Bot 2010-10-18 17:17:58 PDT
Comment on attachment 71097 [details]
Patch for landing

Rejecting patch 71097 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71097]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=71097&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47855&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 71097 from bug 47855.
Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4438087
Comment 7 Eric Seidel (no email) 2010-10-18 19:13:41 PDT
Committed r70016: <http://trac.webkit.org/changeset/70016>
Comment 8 WebKit Review Bot 2010-10-18 20:05:51 PDT
http://trac.webkit.org/changeset/70016 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
media/video-zoom.html