Bug 47847 – Add Queue class and add minimal unittesting of QueueStatusServer code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Add Queue class and add minimal unittesting of QueueStatusServer code

[Eric Seidel (no email)]

Created attachment 71081 [details]
Patch

[Adam Barth]

Comment on attachment 71081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71081&action=review

404!

> WebKitTools/QueueStatusServer/model/queues.py:73
> +    def short_name(self):
> +        # HACK: chromium-ews is incorrectly named.
> +        short_name = self._name.replace("chromium-ews", "Cr-Linux-ews")
> +        short_name = short_name.replace("-ews", "")
> +        short_name = short_name.replace("-queue", "")
> +        return self._caplitalize_after_dash(short_name.capitalize())

This is all ridiculous.

[Eric Seidel (no email)]

(In reply to comment #2)
> > WebKitTools/QueueStatusServer/model/queues.py:73
> > +    def short_name(self):
> > +        # HACK: chromium-ews is incorrectly named.
> > +        short_name = self._name.replace("chromium-ews", "Cr-Linux-ews")
> > +        short_name = short_name.replace("-ews", "")
> > +        short_name = short_name.replace("-queue", "")
> > +        return self._caplitalize_after_dash(short_name.capitalize())
> 
> This is all ridiculous.

It's just there to match the previous manual array mapping from one to the other.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 71081 [details]:

fast/dom/HTMLScriptElement/script-set-src.html

Please file bugs against the tests.  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 71081 [details]
Patch

Clearing flags on attachment: 71081

Committed r70006: <http://trac.webkit.org/changeset/70006>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 71081 [details]:

http/tests/websocket/tests/close-on-unload-reference-in-parent.html

Please file bugs against the tests.  The commit-queue is continuing to process your patch.