Bug 47792 - dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
Summary: dump-as-markup conversion: editing/execCommand/remove-formatting.html and rem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 43017
  Show dependency tree / graph
 
Reported: 2010-10-17 21:56 PDT by Ryosuke Niwa
Modified: 2010-10-18 23:34 PDT (History)
4 users (show)

See Also:

Attachments
converts tests (32.38 KB, patch)
2010-10-17 22:22 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
converts tests (32.38 KB, patch)
2010-10-17 22:28 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
converts tests (32.38 KB, patch)
2010-10-17 22:31 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
fixed per tkent's comments (32.36 KB, patch)
2010-10-18 11:38 PDT, Ryosuke Niwa 		tkent: review+
tkent: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-10-17 21:56:37 PDT 
The following tests should be converted to dump-as-markup tests:
editing/execCommand/remove-formatting.html
editing/execCommand/remove-formatting-2.html
Comment 1 Ryosuke Niwa 2010-10-17 22:22:15 PDT 
Created attachment 70996 [details]
converts tests
Comment 2 Ryosuke Niwa 2010-10-17 22:28:03 PDT 
Created attachment 70997 [details]
converts tests
Comment 3 Ryosuke Niwa 2010-10-17 22:31:19 PDT 
Created attachment 70998 [details]
converts tests
Comment 4 Kent Tamura 2010-10-17 22:40:54 PDT 
Comment on attachment 70998 [details]
converts tests

View in context: https://bugs.webkit.org/attachment.cgi?id=70998&action=review

> LayoutTests/editing/execCommand/remove-formatting.html:15
> +    layoutTestController.dumpAsText();

No need to call dumpAsText().  dump-as-markup.js calls it.

> LayoutTests/platform/qt/editing/execCommand/remove-formatting-expected.txt:-25
> -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification

This sequence of editing callbacks looks different from other ports.  Is it safe to remove this?
Comment 5 Ryosuke Niwa 2010-10-17 22:52:48 PDT 
(In reply to comment #4)
> (From update of attachment 70998 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70998&action=review
> 
> > LayoutTests/editing/execCommand/remove-formatting.html:15
> > +    layoutTestController.dumpAsText();
> 
> No need to call dumpAsText().  dump-as-markup.js calls it.

Oops, will fix.

> > LayoutTests/platform/qt/editing/execCommand/remove-formatting-expected.txt:-25
> > -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
> 
> This sequence of editing callbacks looks different from other ports.  Is it safe to remove this?

Mn... we might need to add platform-specific results later then.
Comment 6 Ryosuke Niwa 2010-10-18 11:38:47 PDT 
Created attachment 71066 [details]
fixed per tkent's comments
Comment 7 Kent Tamura 2010-10-18 21:56:17 PDT 
Comment on attachment 71066 [details]
fixed per tkent's comments

ok.
Please take care of Qt bot after committing this.
Comment 8 Ryosuke Niwa 2010-10-18 23:34:36 PDT 
Committed r70031: <http://trac.webkit.org/changeset/70031>