Bug 47784 - dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html
Summary: dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 43017
  Show dependency tree / graph
 
Reported: 2010-10-17 15:22 PDT by Ryosuke Niwa
Modified: 2010-10-18 12:14 PDT (History)
4 users (show)

See Also:

Attachments
converted tests (29.97 KB, patch)
2010-10-17 16:11 PDT, Ryosuke Niwa 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-10-17 15:22:30 PDT 
The following tests should be converted to dump-as-markup tests:
editing/execCommand/4920742-1.html
editing/execCommand/5049671.html
editing/execCommand/5573879.html
Comment 1 Ryosuke Niwa 2010-10-17 16:11:05 PDT 
Created attachment 70987 [details]
converted tests
Comment 2 Kent Tamura 2010-10-17 22:31:31 PDT 
Comment on attachment 70987 [details]
converted tests

ok.
BTW, I don't like number-only test names.  Probably names like remove-format-5049671.html is better.
Comment 3 Ryosuke Niwa 2010-10-17 22:51:04 PDT 
Thanks for the review!

(In reply to comment #2)
> (From update of attachment 70987 [details])
> ok.
> BTW, I don't like number-only test names.  Probably names like remove-format-5049671.html is better.

yeah, I think all new tests are given more descriptive file names.
Comment 4 Ryosuke Niwa 2010-10-18 12:14:26 PDT 
Committed r69982: <http://trac.webkit.org/changeset/69982>