Bug 47571 – [Qt] AC rendering bugs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Girish Ramakrishnan]

Bugs in Qt's AC implementation
1. When Scrolling the view, the items don't move correctly. This is reproducible using http://webkit.org/blog-files/pulse.html. Just make the view small enough and scroll vertically. The div gets clipped. 


2. For AC/plugins (see 35524), the plugin layer moves incorrectly when scrolling.

3. When clicking on the plugin, the plugin moves/increases in size.

[Noam Rosenthal]

Created attachment 71030 [details]
Patch for the scroll issue

[Noam Rosenthal]

Created attachment 71031 [details]
Patch: second rendering bug (clicking a plugin)

[Andreas Kling]

Comment on attachment 71030 [details]
Patch for the scroll issue

LGTM.

[Andreas Kling]

Comment on attachment 71031 [details]
Patch: second rendering bug (clicking a plugin)

View in context: https://bugs.webkit.org/attachment.cgi?id=71031&action=review

LGTM.

> WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:864
> +            return;

Nit: "break;" would fit better in this context.

[Girish Ramakrishnan]

The scroll patch breaks youtube for me (scrolls fine but nothing renders).

Patches rebased over r69947

[Girish Ramakrishnan]

Scrolling works after applying both patches. Can we commit them as a single patch (or split them correctly?)

[Girish Ramakrishnan]

Err, sorry for the confusion. I had some patches before noam's patches. All good, commit in any order.

[WebKit Commit Bot]

Comment on attachment 71030 [details]
Patch for the scroll issue

Clearing flags on attachment: 71030

Committed r69966: <http://trac.webkit.org/changeset/69966>

[WebKit Commit Bot]

Comment on attachment 71031 [details]
Patch: second rendering bug (clicking a plugin)

Clearing flags on attachment: 71031

Committed r69971: <http://trac.webkit.org/changeset/69971>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/69971 might have broken Qt Windows 32-bit Release

[Ademar Reis]

Removing bug 39121 (qtwebkit-2.1 release critical meta bug) from the list of blockers because this change won't be integrated into qtwebkit-2.1 without the other changes related to bug 35524, which already blocks bug 39121