Bug 47485 - SubframeLoader should call setNeedsStyleRecalc() after creating plugin
Summary: SubframeLoader should call setNeedsStyleRecalc() after creating plugin
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35524
  Show dependency treegraph
 
Reported: 2010-10-11 01:52 PDT by Girish Ramakrishnan
Modified: 2010-10-11 08:07 PDT (History)
2 users (show)

See Also:


Attachments
Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING) (1.83 KB, patch)
2010-10-11 01:54 PDT, Girish Ramakrishnan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Girish Ramakrishnan 2010-10-11 01:52:02 PDT
RenderLayerCompositor uses setNeedsStyleRecalc() to trigger acclerated compositing layers. This change is a precursor to adding accelerated compositing support for NPAPI plugins.

See 35524 for AC support for NPAPI plugins in Qt.
Comment 1 Girish Ramakrishnan 2010-10-11 01:54:31 PDT
Created attachment 70428 [details]
Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING)
Comment 2 Simon Fraser (smfr) 2010-10-11 07:40:48 PDT
Comment on attachment 70428 [details]
Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING)

View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review

> WebCore/loader/SubframeLoader.cpp:371
>      pluginElement->setNeedsStyleRecalc(SyntheticStyleChange);

Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same?
Comment 3 Girish Ramakrishnan 2010-10-11 08:06:50 PDT
(In reply to comment #2)
> (From update of attachment 70428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review
> 
> > WebCore/loader/SubframeLoader.cpp:371
> >      pluginElement->setNeedsStyleRecalc(SyntheticStyleChange);
> 
> Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same?

Indeed. It is indeed better to make this platform specific since one needs to let the compositor know only if AC is supported by the Chrome and WebKit port supports AC for plugins in that chrome.