RESOLVED INVALID Bug 47485
SubframeLoader should call setNeedsStyleRecalc() after creating plugin 
https://bugs.webkit.org/show_bug.cgi?id=47485
Summary SubframeLoader should call setNeedsStyleRecalc() after creating plugin
Girish Ramakrishnan
Reported 2010-10-11 01:52:02 PDT
RenderLayerCompositor uses setNeedsStyleRecalc() to trigger acclerated compositing layers. This change is a precursor to adding accelerated compositing support for NPAPI plugins. See 35524 for AC support for NPAPI plugins in Qt.
Attachments
Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING) (1.83 KB, patch)
2010-10-11 01:54 PDT, Girish Ramakrishnan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1 2010-10-11 01:54:31 PDT
Created attachment 70428 [details] Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING)
Simon Fraser (smfr)
Comment 2 2010-10-11 07:40:48 PDT
Comment on attachment 70428 [details] Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING) View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review > WebCore/loader/SubframeLoader.cpp:371 > pluginElement->setNeedsStyleRecalc(SyntheticStyleChange); Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same?
Girish Ramakrishnan
Comment 3 2010-10-11 08:06:50 PDT
(In reply to comment #2) > (From update of attachment 70428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review > > > WebCore/loader/SubframeLoader.cpp:371 > > pluginElement->setNeedsStyleRecalc(SyntheticStyleChange); > > Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same? Indeed. It is indeed better to make this platform specific since one needs to let the compositor know only if AC is supported by the Chrome and WebKit port supports AC for plugins in that chrome.
Note You need to log in before you can comment on or make changes to this bug.