Bug 47418 - Make PluginView inherit from PluginViewBase.
Summary: Make PluginView inherit from PluginViewBase.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35524
  Show dependency tree / graph
 
Reported: 2010-10-08 09:06 PDT by Girish Ramakrishnan
Modified: 2010-10-21 13:34 PDT (History)
3 users (show)

See Also:

Attachments
Make PluginView inherit from PluginViewBase (2.55 KB, patch)
2010-10-08 09:10 PDT, Girish Ramakrishnan 		andersca: review-
Details | Formatted Diff | Diff
Take2 (4.12 KB, patch)
2010-10-11 13:59 PDT, Girish Ramakrishnan 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Girish Ramakrishnan 2010-10-08 09:06:36 PDT 
As part of #35524, I am implementing AC for NPAPI plugins. The AC code requires plugins to derive from PluginViewBase.
Comment 1 Girish Ramakrishnan 2010-10-08 09:10:15 PDT 
Created attachment 70257 [details]
Make PluginView inherit from PluginViewBase
Comment 2 Girish Ramakrishnan 2010-10-08 12:38:58 PDT 
You can find rest of the patch series here - http://gitorious.org/~girish/webkit/girishs-webkit/commits/plugins_ac_35524
Comment 3 Girish Ramakrishnan 2010-10-11 10:15:16 PDT 
I see that Page::privateBrowsingStateChanged could do with some fixing, do you want me to do that as part of this change?
Comment 4 Anders Carlsson 2010-10-11 12:43:40 PDT 
(In reply to comment #3)
> I see that Page::privateBrowsingStateChanged could do with some fixing, do you want me to do that as part of this change?

Yes, that would be great! I'll r- the patch.
Comment 5 Girish Ramakrishnan 2010-10-11 13:59:03 PDT 
Created attachment 70465 [details]
Take2
Comment 6 Girish Ramakrishnan 2010-10-12 14:36:07 PDT 
Anders, can you review this please?
Comment 7 Anders Carlsson 2010-10-12 15:12:25 PDT 
Comment on attachment 70465 [details]
Take2

Looks good.
Comment 8 Girish Ramakrishnan 2010-10-12 21:13:01 PDT 
Landed in http://trac.webkit.org/changeset/69635.
Comment 9 Ademar Reis 2010-10-21 13:34:37 PDT 
Removing bug 39121 (qtwebkit-2.1 release critical meta bug) from the list of blockers because this change won't be integrated into qtwebkit-2.1 without the other changes related to bug 35524, which already blocks bug 39121