WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
47418
Make PluginView inherit from PluginViewBase.
https://bugs.webkit.org/show_bug.cgi?id=47418
Summary
Make PluginView inherit from PluginViewBase.
Girish Ramakrishnan
Reported
2010-10-08 09:06:36 PDT
As part of #35524, I am implementing AC for NPAPI plugins. The AC code requires plugins to derive from PluginViewBase.
Attachments
Make PluginView inherit from PluginViewBase
(2.55 KB, patch)
2010-10-08 09:10 PDT
,
Girish Ramakrishnan
andersca
: review-
Details
Formatted Diff
Diff
Take2
(4.12 KB, patch)
2010-10-11 13:59 PDT
,
Girish Ramakrishnan
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Girish Ramakrishnan
Comment 1
2010-10-08 09:10:15 PDT
Created
attachment 70257
[details]
Make PluginView inherit from PluginViewBase
Girish Ramakrishnan
Comment 2
2010-10-08 12:38:58 PDT
You can find rest of the patch series here -
http://gitorious.org/~girish/webkit/girishs-webkit/commits/plugins_ac_35524
Girish Ramakrishnan
Comment 3
2010-10-11 10:15:16 PDT
I see that Page::privateBrowsingStateChanged could do with some fixing, do you want me to do that as part of this change?
Anders Carlsson
Comment 4
2010-10-11 12:43:40 PDT
(In reply to
comment #3
)
> I see that Page::privateBrowsingStateChanged could do with some fixing, do you want me to do that as part of this change?
Yes, that would be great! I'll r- the patch.
Girish Ramakrishnan
Comment 5
2010-10-11 13:59:03 PDT
Created
attachment 70465
[details]
Take2
Girish Ramakrishnan
Comment 6
2010-10-12 14:36:07 PDT
Anders, can you review this please?
Anders Carlsson
Comment 7
2010-10-12 15:12:25 PDT
Comment on
attachment 70465
[details]
Take2 Looks good.
Girish Ramakrishnan
Comment 8
2010-10-12 21:13:01 PDT
Landed in
http://trac.webkit.org/changeset/69635
.
Ademar Reis
Comment 9
2010-10-21 13:34:37 PDT
Removing
bug 39121
(qtwebkit-2.1 release critical meta bug) from the list of blockers because this change won't be integrated into qtwebkit-2.1 without the other changes related to
bug 35524
, which already blocks
bug 39121
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug