Bug 47380 - [V8] Add FileWriter to active DOM map
Summary: [V8] Add FileWriter to active DOM map
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Eric U.
Depends on:
Blocks: 44358
  Show dependency treegraph
Reported: 2010-10-07 14:28 PDT by Eric U.
Modified: 2010-10-07 19:03 PDT (History)
4 users (show)

See Also:

One-liner. (1019 bytes, patch)
2010-10-07 17:58 PDT, Eric U.
jianli: review-
Details | Formatted Diff | Diff
Fixed ChangeLog and bug title. (1021 bytes, patch)
2010-10-07 18:27 PDT, Eric U.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric U. 2010-10-07 14:28:54 PDT
As in https://bugs.webkit.org/show_bug.cgi?id=47205, it needs to be added in CodeGeneratorV8.pm.
However, it's not directly constructable, so it doesn't need the custom constructor.  The ref() is done in wrapSlow(), which gets called via FileWriterCallback.
Comment 1 Eric U. 2010-10-07 17:58:42 PDT
Created attachment 70181 [details]

Hope this works; I haven't created a patch manually on Windows before.
Comment 2 Jian Li 2010-10-07 18:02:06 PDT
Comment on attachment 70181 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=70181&action=review

> WebCore/ChangeLog:5
> +        Add FileWriter to V8 active DOM map

Please add "[V8]" prefix to the bug title and also update the ChangeLog.
Comment 3 Eric U. 2010-10-07 18:27:10 PDT
Created attachment 70183 [details]
Fixed ChangeLog and bug title.
Comment 4 WebKit Commit Bot 2010-10-07 19:03:28 PDT
Comment on attachment 70183 [details]
Fixed ChangeLog and bug title.

Clearing flags on attachment: 70183

Committed r69370: <http://trac.webkit.org/changeset/69370>
Comment 5 WebKit Commit Bot 2010-10-07 19:03:33 PDT
All reviewed patches have been landed.  Closing bug.