Bug 47205 - [V8] Add FileReader to active DOM map
Summary: [V8] Add FileReader to active DOM map
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-05 13:34 PDT by Jian Li
Modified: 2010-10-05 14:41 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (5.13 KB, patch)
2010-10-05 13:46 PDT, Jian Li 		japhet: review+
jianli: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-10-05 13:34:43 PDT 
We need to add FileReader to active DOM map in V8 bindings such that it will not be GC-ed when it is still active. This is needed to fix the Chromium bug: http://code.google.com/p/chromium/issues/detail?id=56997
Comment 1 Jian Li 2010-10-05 13:46:19 PDT 
Created attachment 69835 [details]
Proposed Patch
Comment 2 Nate Chapin 2010-10-05 14:03:51 PDT 
Comment on attachment 69835 [details]
Proposed Patch

Please also add this file to Android.v8bindings.mk and WebCore.pro before submitting.
Comment 3 Jian Li 2010-10-05 14:41:25 PDT 
Commited as http://trac.webkit.org/changeset/69148.

Add the new file to Android.v8bindings.mk. I do not add it to WebCore.pro since it seems not to be using V8 bindings.