Bug 47335 - Move user stylesheet test into platform independent directory
Summary: Move user stylesheet test into platform independent directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 02:47 PDT by Patrick R. Gansterer
Modified: 2010-12-13 11:19 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2010-10-07 02:53 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-10-07 02:47:40 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-10-07 02:53:54 PDT 
Created attachment 70062 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-13 00:38:39 PST 
Comment on attachment 70062 [details]
Patch

LGTM!
Comment 3 WebKit Review Bot 2010-12-13 02:00:46 PST 
Comment on attachment 70062 [details]
Patch

Clearing flags on attachment: 70062

Committed r73893: <http://trac.webkit.org/changeset/73893>
Comment 4 WebKit Review Bot 2010-12-13 02:00:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-12-13 03:42:52 PST 
http://trac.webkit.org/changeset/73893 might have broken Qt Linux Release
The following tests are not passing:
fast/loader/user-stylesheet-fast-path.html
Comment 6 Csaba Osztrogonác 2010-12-13 03:53:20 PST 
(In reply to comment #5)
> http://trac.webkit.org/changeset/73893 might have broken Qt Linux Release
> The following tests are not passing:
> fast/loader/user-stylesheet-fast-path.html

New bug filed on it: https://bugs.webkit.org/show_bug.cgi?id=50911
Comment 7 Eric Seidel (no email) 2010-12-13 11:11:26 PST 
pfeldman believes this broken on Chromium:
http://code.google.com/p/chromium/issues/detail?id=66686

At least I think.  i can't tell from that bug.
Comment 8 Eric Seidel (no email) 2010-12-13 11:18:36 PST 
Given the number of platforms this appears to fail on, we may wish to roll this out.  Patrick?
Comment 9 Patrick R. Gansterer 2010-12-13 11:19:57 PST 
(In reply to comment #8)
> Given the number of platforms this appears to fail on, we may wish to roll this out.  Patrick?
I think we should add it to the different skip lists istead of rolling out.