Bug 50911 - [Qt] fast/loader/user-stylesheet-fast-path.html fails
Summary: [Qt] fast/loader/user-stylesheet-fast-path.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-12-13 03:52 PST by Csaba Osztrogonác
Modified: 2011-02-27 10:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.70 KB, patch)
2011-02-27 06:28 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-12-13 03:52:45 PST 
http://trac.webkit.org/changeset/73893 made this test to be 
a platform independent test and unfortunately it fails on Qt.

patch to get detailed results:
-------------------------------
--- a/LayoutTests/fast/loader/user-stylesheet-fast-path.html
+++ b/LayoutTests/fast/loader/user-stylesheet-fast-path.html
@@ -24,7 +24,7 @@

             document.body.offsetTop;
             var result = getComputedStyle(document.body).fontSize == obj.size;
-            document.write((result == obj.result ? "PASS" : "FAIL") + " " + obj.size + "<br>");
+            document.write((result == obj.result ? "PASS" : "FAIL") + " expected:" + obj.result + " actual:" + result + " "+ obj.size + " " + getComputedStyle(document.body).fontSize+ "<br>");

             layoutTestController.setUserStyleSheetLocation("");
         }

DRT result:
------------
PASS expected:true actual:true 100px 100px
PASS expected:true actual:true 110px 110px
FAIL expected:true actual:false 120px 16px
PASS expected:true actual:true 130px 130px
PASS expected:false actual:false 140px 16px
PASS expected:false actual:false 150px 16px
PASS expected:false actual:false 160px 16px
Comment 1 Patrick R. Gansterer 2011-02-27 06:28:36 PST 
Created attachment 83974 [details]
Patch
Comment 2 Andreas Kling 2011-02-27 08:04:20 PST 
Comment on attachment 83974 [details]
Patch

Awesome, thanks for fixing!
Comment 3 WebKit Commit Bot 2011-02-27 09:59:50 PST 
Comment on attachment 83974 [details]
Patch

Clearing flags on attachment: 83974

Committed r79820: <http://trac.webkit.org/changeset/79820>
Comment 4 WebKit Commit Bot 2011-02-27 09:59:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2011-02-27 10:40:19 PST 
The commit-queue encountered the following flaky tests while processing attachment 83974 [details]:

http/tests/websocket/tests/simple.html bug 55325 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.