Bug 47116 - Uninitialized memory in WebGraphicsContext3DDefaultImpl::angleCreateCompilers()
Summary: Uninitialized memory in WebGraphicsContext3DDefaultImpl::angleCreateCompilers()
Status: RESOLVED DUPLICATE of bug 47024
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 14:43 PDT by Stephen White
Modified: 2010-10-06 08:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2010-10-04 14:45 PDT, Stephen White 		levin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-10-04 14:43:45 PDT 
Uninitialized memory in WebGraphicsContext3DDefaultImpl::angleCreateCompilers()
Comment 1 Stephen White 2010-10-04 14:45:57 PDT 
Created attachment 69686 [details]
Patch
Comment 2 Stephen White 2010-10-04 14:47:05 PDT 
This does fix the valgrind error, but I'm not sure if 0 is the correct value.
Comment 3 Kenneth Russell 2010-10-04 16:57:09 PDT 
I think Alok is in the process of fixing this differently in https://bugs.webkit.org/show_bug.cgi?id=47024 .
Comment 4 Kenneth Russell 2010-10-05 11:26:43 PDT 
https://bugs.webkit.org/show_bug.cgi?id=47024 has been added to the commit queue. Would you mind retesting once that lands and see whether it clears up this failure?
Comment 5 Stephen White 2010-10-05 11:41:23 PDT 
That looks like it should work (and looks better, since it uses the Sh function to do it, which I was too scared to do).  Will take a look once it lands.
Comment 6 David Levin 2010-10-05 13:06:26 PDT 
Comment on attachment 69686 [details]
Patch

Per the comments in the bug another (better?) patch will fix this.
Comment 7 Stephen White 2010-10-06 08:48:47 PDT 
(In reply to comment #5)
> That looks like it should work (and looks better, since it uses the Sh function to do it, which I was too scared to do).  Will take a look once it lands.

OK, verified that it's fixed by the other patch.

*** This bug has been marked as a duplicate of bug 47024 ***