RESOLVED DUPLICATE of bug 4702447116
Uninitialized memory in WebGraphicsContext3DDefaultImpl::angleCreateCompilers() 
https://bugs.webkit.org/show_bug.cgi?id=47116
Summary Uninitialized memory in WebGraphicsContext3DDefaultImpl::angleCreateCompilers()
Stephen White
Reported 2010-10-04 14:43:45 PDT
Uninitialized memory in WebGraphicsContext3DDefaultImpl::angleCreateCompilers()
Attachments
Patch (1.30 KB, patch)
2010-10-04 14:45 PDT, Stephen White 		levin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2010-10-04 14:45:57 PDT
Created attachment 69686 [details] Patch
Stephen White
Comment 2 2010-10-04 14:47:05 PDT
This does fix the valgrind error, but I'm not sure if 0 is the correct value.
Kenneth Russell
Comment 3 2010-10-04 16:57:09 PDT
I think Alok is in the process of fixing this differently in https://bugs.webkit.org/show_bug.cgi?id=47024 .
Kenneth Russell
Comment 4 2010-10-05 11:26:43 PDT
https://bugs.webkit.org/show_bug.cgi?id=47024 has been added to the commit queue. Would you mind retesting once that lands and see whether it clears up this failure?
Stephen White
Comment 5 2010-10-05 11:41:23 PDT
That looks like it should work (and looks better, since it uses the Sh function to do it, which I was too scared to do). Will take a look once it lands.
David Levin
Comment 6 2010-10-05 13:06:26 PDT
Comment on attachment 69686 [details] Patch Per the comments in the bug another (better?) patch will fix this.
Stephen White
Comment 7 2010-10-06 08:48:47 PDT
(In reply to comment #5) > That looks like it should work (and looks better, since it uses the Sh function to do it, which I was too scared to do). Will take a look once it lands. OK, verified that it's fixed by the other patch. *** This bug has been marked as a duplicate of bug 47024 ***
Note You need to log in before you can comment on or make changes to this bug.