Bug 47098 - dump-as-markup conversion: editing/execCommand/format-block-with-braces.html and format-block.html
Summary: dump-as-markup conversion: editing/execCommand/format-block-with-braces.html ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 19795
  Show dependency tree / graph
 
Reported: 2010-10-04 11:26 PDT by Ryosuke Niwa
Modified: 2010-10-05 14:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.09 KB, patch)
2010-10-04 11:55 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (39.86 KB, patch)
2010-10-04 12:13 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (39.31 KB, patch)
2010-10-04 12:18 PDT, Ryosuke Niwa 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-10-04 11:26:37 PDT 
editing/execCommand/format-block.html should be converted to a dump-as-markup test since it's testing the DOM modifications done by execCommand("FormatBlock");
Comment 1 Ryosuke Niwa 2010-10-04 11:55:03 PDT 
Created attachment 69657 [details]
Patch
Comment 2 Ryosuke Niwa 2010-10-04 12:01:57 PDT 
editing/execCommand/format-block-with-braces.html should be converted as well.
Comment 3 Ryosuke Niwa 2010-10-04 12:13:00 PDT 
Created attachment 69662 [details]
Patch
Comment 4 Ryosuke Niwa 2010-10-04 12:18:59 PDT 
Created attachment 69666 [details]
Patch
Comment 5 Tony Chang 2010-10-04 15:05:35 PDT 
Comment on attachment 69666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69666&action=review

> LayoutTests/editing/execCommand/format-block-with-braces.html:3
> +<!DOCTYPE html>
> +<html>
> +<body>

I don't know if we have a policy on whether tests should have doctype, html or body tags.  I think on webkit-dev mjs said he likes the <!DOCTYPE html> tag because we want to be testing the standards compliant parser.  That said, since this is an existing test and it didn't have these tags originally, I kind of think the test should not have these tags (i.e., it's more like a regression test).

I don't have a strong opinion one way or another and it shouldn't matter at all for this test, so either is fine with me.
Comment 6 Ryosuke Niwa 2010-10-05 14:38:05 PDT 
Committed r69147: <http://trac.webkit.org/changeset/69147>