Bug 46355 – Fix usage of enum as if it was a define

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Lucas De Marchi]

Fix usage of enum as if it was a define

[Lucas De Marchi]

Created attachment 68522 [details]
Patch

[Csaba Osztrogonác]

Here is a related bug: https://bugs.webkit.org/show_bug.cgi?id=45246

Zoltan, Darin, could you check it?

[Darin Adler]

Comment on attachment 68522 [details]
Patch

I am not sure we need two code paths here. The person who originally made this patch was trying to preserve the faster simpler code path for platforms like Mac OS X where the default for a mutex is a normal mutex, but I think we can take the extra hit of always calling pthread_mutexattr_init on all platforms. So lets just get rid of the #if and keep only the #else part.

Unless someone has evidence that the code is too slow when written that way.

[Lucas De Marchi]

(In reply to comment #3)
> (From update of attachment 68522 [details])
> I am not sure we need two code paths here. The person who originally made this patch was trying to preserve the faster simpler code path for platforms like Mac OS X where the default for a mutex is a normal mutex, but I think we can take the extra hit of always calling pthread_mutexattr_init on all platforms. So lets just get rid of the #if and keep only the #else part.
> 
> Unless someone has evidence that the code is too slow when written that way.

Humn... Yes, I agree. I'll upload a new patch soon.

[Lucas De Marchi]

Created attachment 68559 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 68559 [details]
Patch

Clearing flags on attachment: 68559

Committed r68209: <http://trac.webkit.org/changeset/68209>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.