Bug 46347 - [Qt] Remove setDeviceSize methods
Summary: [Qt] Remove setDeviceSize methods
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Major
Assignee: Nobody
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31552
  Show dependency treegraph
Reported: 2010-09-23 06:37 PDT by Kenneth Rohde Christiansen
Modified: 2010-10-06 07:38 PDT (History)
3 users (show)

See Also:

Patch (8.87 KB, patch)
2010-09-27 10:39 PDT, Kenneth Rohde Christiansen
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2010-09-23 06:37:51 PDT
These methods are not in 2.0 and we do not want them in 2.1. Instead the viewport meta tag stuff should use QDesktopServices to get the device size.

device-width is the width of the device when in portrait and the device-height is the width of the device when in landscape.

It would be nice to have some environment variables to overwrite the values when testing mobile browsers on the desktop.
Comment 1 Kenneth Rohde Christiansen 2010-09-23 06:55:11 PDT
QDesktopWidget should have what we need. We just need to make sure that the geometry gives the actual screen geometry and doesn't subtract things like the cellphone status area.
Comment 2 Kenneth Rohde Christiansen 2010-09-27 10:39:39 PDT
Created attachment 68928 [details]
Comment 3 Kenneth Rohde Christiansen 2010-09-27 17:31:26 PDT
Fixed (after conversation on irc) version landed in r68457
Comment 4 Simon Hausmann 2010-10-05 06:29:16 PDT
<cherry-pick-for-backport: r68457>
Comment 5 Simon Hausmann 2010-10-05 06:29:33 PDT
<cherry-pick-for-backport: r69104>
Comment 6 Ademar Reis 2010-10-06 07:38:11 PDT
Revision r68457 cherry-picked into qtwebkit-2.1 with commit b2d63cf <http://gitorious.org/webkit/qtwebkit/commit/b2d63cf>
Revision r69104 cherry-picked into qtwebkit-2.1 with commit 69b269b <http://gitorious.org/webkit/qtwebkit/commit/69b269b>