RESOLVED FIXED 46333
commit-queue should log more detailed messages to the QueueStatusServer 
https://bugs.webkit.org/show_bug.cgi?id=46333
Summary commit-queue should log more detailed messages to the QueueStatusServer
Adam Barth
Reported 2010-09-22 19:39:23 PDT
commit-queue should log more detailed messages to the QueueStatusServer
Attachments
Patch (14.88 KB, patch)
2010-09-22 19:41 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-09-22 19:41:40 PDT
Created attachment 68493 [details] Patch
Eric Seidel (no email)
Comment 2 2010-09-22 20:02:25 PDT
Comment on attachment 68493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68493&action=review Looks OK. > WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:71 > + "Applied path", patch? > WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:122 > + "Unable to pass tests without patch") Sounds like it might pass fine with it... but don't you dare take the patch away! :p We could have it include the revision number in these messages. But that may be a separate patch.
Adam Barth
Comment 3 2010-09-22 20:11:53 PDT
Committed r68117: <http://trac.webkit.org/changeset/68117>
Mihai Parparita
Comment 4 2010-09-22 22:06:35 PDT
(In reply to comment #2) > We could have it include the revision number in these messages. But that may be a separate patch. BTW, it might also be nice to have a way of passing the bot machine name with these messages (or associating it with a patch ID earlier). The grouping on the queue status server gets a bit confused when multiple bots are sending status updates in parallel (we might have to sacrifice strict chronological ordering, or there could be one status list per bot).
Adam Barth
Comment 5 2010-09-22 22:08:50 PDT
Yeah, the page is pretty confusing now.
Note You need to log in before you can comment on or make changes to this bug.