Bug 176332 – EWS should report when a step succeeds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Most of the EWS report only if a step fails, but do not report when a step succeed. For e.g.: If a build succeeds, EWS does not report it. Information about a step passing is sometimes very valuable, especially when waiting for a patch to complete processing. Sometimes, patch authors know that their changes are not covered by any tests. It makes little sense to wait for tests to run in this case. See <rdar://problem/25224607>

StyleQueue and CommitQueue do report both pass and fail status of a step. For e.g.: See the difference in logging between CommitQueue and ios-ews: 
https://webkit-queues.webkit.org/patch/285756/ios-ews
https://webkit-queues.webkit.org/patch/285756/commit-queue

All the Queues should report passing status of steps as well.

[Aakash Jain]

After the change to have individual web-pages for each EWS queue (https://bugs.webkit.org/show_bug.cgi?id=174477), we can display more information about the patch without hurting the UI.

[Aakash Jain]

Created attachment 319860 [details]
Proposed patch

[Sam Weinig]

Comment on attachment 319860 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319860&action=review

> Tools/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Nice. The ChangeLog could use a bit more of a 'why' description.  You have a pretty good one in the first comment of the bug which should take you most of the way there!

[Alexey Proskuryakov]

Does this change also propagate to the popover? How does it look after the build succeeds?

[Aakash Jain]

Created attachment 319874 [details]
Screenshot_bubbles_during_processing

[Aakash Jain]

Created attachment 319875 [details]
Screenshot_bubbles_after_processing

[Aakash Jain]

(In reply to Alexey Proskuryakov from comment #4)
> Does this change also propagate to the popover?

Yes, the pop-over does show these messages in "Recent messages" section. That should help developers to just hover over the bubbles and get more insight into what's going on.

>  How does it look after the build succeeds?
No change from earlier. It shows Pass status.

Screenshots attached from testing instance.

[Aakash Jain]

Created attachment 319896 [details]
Patch with updated ChangeLog

[WebKit Commit Bot]

Comment on attachment 319896 [details]
Patch with updated ChangeLog

Clearing flags on attachment: 319896

Committed r221649: <http://trac.webkit.org/changeset/221649>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.