Bug 46135 – new-run-webkit-tests: refactor command line args getting passed to DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

new-run-webkit-tests: refactor command line args getting passed to DRT

[Dirk Pranke]

Created attachment 68155 [details]
Patch

[Dirk Pranke]

Created attachment 68159 [details]
Patch

[Ojan Vafai]

Comment on attachment 68159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68159&action=review

Looks like an improvement. Please fix the style nit.

> WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:353
> +        if self._image_path:
> +            driver_args.append("--pixel-tests=" + self._image_path)
> +        if self._options.use_drt:
> +            driver_args.append('--test-shell')
> +        else:
> +            driver_args.append('--layout-tests')
> +        if self._options.startup_dialog:
> +            driver_args.append('--testshell-startup-dialog')
> +        if self._options.gp_fault_error_box:
> +            driver_args.append('--gp-fault-error-box')

style nit: this needs some line breaks to be more readable. I'd personally put a line break after each if and if-else clause, but just a line break before and after the if-else clause would help.

[Dirk Pranke]

(In reply to comment #3)
> (From update of attachment 68159 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68159&action=review
> 
> Looks like an improvement. Please fix the style nit.
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:353
> > +        if self._image_path:
> > +            driver_args.append("--pixel-tests=" + self._image_path)
> > +        if self._options.use_drt:
> > +            driver_args.append('--test-shell')
> > +        else:
> > +            driver_args.append('--layout-tests')
> > +        if self._options.startup_dialog:
> > +            driver_args.append('--testshell-startup-dialog')
> > +        if self._options.gp_fault_error_box:
> > +            driver_args.append('--gp-fault-error-box')
> 
> style nit: this needs some line breaks to be more readable. I'd personally put a line break after each if and if-else clause, but just a line break before and after the if-else clause would help.

done. Thanks!

[Dirk Pranke]

Committed r67905: <http://trac.webkit.org/changeset/67905>

[Tony Chang]

This is causing all tests on DRT to fail on Mac:
https://bugs.webkit.org/show_bug.cgi?id=46230

[Dirk Pranke]

This should be fixed as of r67993 (hopefully). See bug 46230 for more.