RESOLVED FIXED Bug 46230
[chromium] REGRESSION(r67905): DRT test shell ALWAYS crashes on Mac 
https://bugs.webkit.org/show_bug.cgi?id=46230
Summary [chromium] REGRESSION(r67905): DRT test shell ALWAYS crashes on Mac
Ryosuke Niwa
Reported 2010-09-21 16:35:29 PDT
chromium DRT crashes for all tests on Mac with the error "--pixel-tests with --test-shell requires a file name." See http://build.webkit.org/builders/Chromium%20Mac%20Release%20(Tests)/builds/2160/steps/layout-test/logs/stdio for how this bug is affecting the cr-mac bot.
Attachments
Patch (1.62 KB, patch)
2010-09-21 17:04 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-09-21 16:46:24 PDT
The root cause seems to be http://trac.webkit.org/changeset/67905.
Dirk Pranke
Comment 2 2010-09-21 17:04:46 PDT
Created attachment 68311 [details] Patch
Dirk Pranke
Comment 3 2010-09-21 17:07:18 PDT
Committed r67993: <http://trac.webkit.org/changeset/67993>
Tony Chang
Comment 4 2010-09-21 17:12:42 PDT
Comment on attachment 68311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review Removing the review flag since this was checked in, however: > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418 > + driver_args.append('--pixel-tests' % image_path) This can't be right.
Dirk Pranke
Comment 5 2010-09-21 17:33:22 PDT
Committed r67999: <http://trac.webkit.org/changeset/67999>
Dirk Pranke
Comment 6 2010-09-21 17:38:17 PDT
(In reply to comment #4) > (From update of attachment 68311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68311&action=review > > Removing the review flag since this was checked in, however: > > > WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py:418 > > + driver_args.append('--pixel-tests' % image_path) > > This can't be right. True, it wasn't :(
Dirk Pranke
Comment 7 2010-09-21 17:38:46 PDT
I think r67999 is the right fix. I will watch the bots to find out.
Note You need to log in before you can comment on or make changes to this bug.