Bug 46131 - [chromium] Remove GLES2Context and WebGLES2Context
Summary: [chromium] Remove GLES2Context and WebGLES2Context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 45912 46231
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-20 15:36 PDT by Kenneth Russell
Modified: 2010-09-21 17:34 PDT (History)
6 users (show)

See Also:


Attachments
Patch (25.61 KB, patch)
2010-09-21 17:25 PDT, Kenneth Russell
jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-09-20 15:36:01 PDT
Now that Chromium's compositor has been switched over to use GraphicsContext3D for its rendering, the GLES2Context and WebGLES2Context abstractions need to be removed. Their presence is breaking the Windows multi-DLL build due to multiple inclusions of the command buffer client code and its thread-local variables.
Comment 1 Kenneth Russell 2010-09-21 17:25:20 PDT
Created attachment 68317 [details]
Patch

From the ChangeLog:

Removed now-obsolete GLES2Context and WebGLES2Context classes, and dependency on command buffer client code from WebCore. Built and tested 3D CSS and WebGL content on Mac OS X to test.
Comment 2 James Robinson 2010-09-21 17:26:47 PDT
Comment on attachment 68317 [details]
Patch

R=me
Comment 3 Kenneth Russell 2010-09-21 17:34:50 PDT
Committed r68000: <http://trac.webkit.org/changeset/68000>