WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 46126
Add availableLogicalWidth to RenderBox.
https://bugs.webkit.org/show_bug.cgi?id=46126
Summary
Add availableLogicalWidth to RenderBox.
Dave Hyatt
Reported
2010-09-20 14:55:23 PDT
availableLogicalWidth() needs to be implemented, since percentage padding depends on it.
Attachments
Patch
(3.85 KB, patch)
2010-09-20 15:28 PDT
,
Dave Hyatt
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2010-09-20 15:28:56 PDT
Created
attachment 68147
[details]
Patch
mitz
Comment 2
2010-09-20 15:31:24 PDT
Comment on
attachment 68147
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=68147&action=review
> WebCore/rendering/RenderBox.cpp:1739 > + if (style()->blockFlow() == TopToBottomBlockFlow || style()->blockFlow() == BottomToTopBlockFlow)
I think you should start considering RenderStyle::blockFlowAxis() or RenderStyle::isVerticalBlockFlow() or something.
Dave Hyatt
Comment 3
2010-09-20 15:36:27 PDT
Yeah I'll add isVerticalTextFlow() in another patch and fix this. Fixed in
r67886
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug