Bug 46126 - Add availableLogicalWidth to RenderBox.
Summary: Add availableLogicalWidth to RenderBox.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46127 46124
  Show dependency tree / graph
 
Reported: 2010-09-20 14:55 PDT by Dave Hyatt
Modified: 2010-09-20 15:36 PDT (History)
0 users

See Also:

Attachments
Patch (3.85 KB, patch)
2010-09-20 15:28 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-20 14:55:23 PDT 
availableLogicalWidth() needs to be implemented, since percentage padding depends on it.
Comment 1 Dave Hyatt 2010-09-20 15:28:56 PDT 
Created attachment 68147 [details]
Patch
Comment 2 mitz 2010-09-20 15:31:24 PDT 
Comment on attachment 68147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68147&action=review

> WebCore/rendering/RenderBox.cpp:1739
> +    if (style()->blockFlow() == TopToBottomBlockFlow || style()->blockFlow() == BottomToTopBlockFlow)

I think you should start considering RenderStyle::blockFlowAxis() or RenderStyle::isVerticalBlockFlow() or something.
Comment 3 Dave Hyatt 2010-09-20 15:36:27 PDT 
Yeah I'll add isVerticalTextFlow() in another patch and fix this.

Fixed in r67886.