Bug 45980 - userscripts/user-script-*-document.html tests are flaky on Windows
Summary: userscripts/user-script-*-document.html tests are flaky on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-09-17 11:22 PDT by Brian Weinstein
Modified: 2010-11-05 11:03 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Fix for plugin documents (2.70 KB, patch)
2010-10-28 16:37 PDT, Brian Weinstein
no flags Details | Formatted Diff | Diff
[PATCH] Fix for video documents (51.51 KB, patch)
2010-11-05 10:48 PDT, Brian Weinstein
eric.carlson: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-09-17 11:22:59 PDT
userscripts/user-script-video-document.html
userscripts/user-script-audio-document.html
userscripts/user-script-plugin-document.html

seem to be flaky on Windows (sometimes they crash or hit ASSERTs, sometimes they print out the wrong results). This is strange, because having tested them in browser, we do get the correct behavior.
Comment 1 Brian Weinstein 2010-09-17 11:35:09 PDT
Skipped the tests in r67729.
Comment 2 Brian Weinstein 2010-09-17 11:41:10 PDT
<rdar://problem/8445830>
Comment 3 Brian Weinstein 2010-10-28 16:37:57 PDT
Created attachment 72257 [details]
[PATCH] Fix for plugin documents
Comment 4 Brian Weinstein 2010-10-28 16:45:19 PDT
Landed fix for plugin documents in r70825.
Comment 5 Brian Weinstein 2010-10-28 16:45:36 PDT
Comment on attachment 72257 [details]
[PATCH] Fix for plugin documents

Clearing review flags.
Comment 6 WebKit Review Bot 2010-10-28 18:04:39 PDT
http://trac.webkit.org/changeset/70825 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
media/video-seek-by-small-increment.html
Comment 7 Brian Weinstein 2010-11-05 10:48:15 PDT
Created attachment 73083 [details]
[PATCH] Fix for video documents
Comment 8 Eric Carlson 2010-11-05 10:52:44 PDT
Comment on attachment 73083 [details]
[PATCH] Fix for video documents

r=me
Comment 9 Brian Weinstein 2010-11-05 11:03:13 PDT
Landed fix for video documents in r71433. I'm closing out this bug, because the only user-script-*-document test that is flaky is user-script-plugin-document - and that is being tracked by: https://bugs.webkit.org/show_bug.cgi?id=48751.