Bug 48751 – Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Adam Roben (:aroben)]

To reproduce:

1. run-webkit-tests userscripts http

You'll hit an assertion in PluginStream::~PluginStream. (run-webkit-tests will blame http/tests/cache/stopped-revalidation.html, but that test doesn't cause a problem on its own.) Here's the failing assertion:

    ASSERT(m_streamState != StreamStarted);

See the URL for the backtrace.

[Adam Roben (:aroben)]

I've added this test to the Skipped file.

[Adam Roben (:aroben)]

<rdar://problem/8615536>

[Brian Weinstein]

Created attachment 72994 [details]
[PATCH] Fix

[WebKit Review Bot]

Attachment 72994 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/win/Skipped', u'WebCore/ChangeLog', u'WebCore/plugins/PluginStream.cpp']" exit_code: 1
WebCore/plugins/PluginStream.cpp:336:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brian Weinstein]

Created attachment 73001 [details]
[PATCH] Style nit fix

[Brian Weinstein]

Comment on attachment 73001 [details]
[PATCH] Style nit fix

Anders expressed doubts about correctness of this patch, so obsoleting it for now - new patch coming shortly.

[Brian Weinstein]

Created attachment 73085 [details]
[PATCH] Fix

[Brian Weinstein]

Will fix the LayoutTests/ChangeLog before landing, thanks Anders!

[Brian Weinstein]

Landed in r71434.