Bug 45914 - [chromium] Expose separate GraphicsContext3DInternal.h
Summary: [chromium] Expose separate GraphicsContext3DInternal.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
Depends on:
Blocks: 45912
  Show dependency treegraph
Reported: 2010-09-16 12:11 PDT by Kenneth Russell
Modified: 2010-09-16 12:31 PDT (History)
3 users (show)

See Also:

Patch (25.24 KB, patch)
2010-09-16 12:15 PDT, Kenneth Russell
jamesr: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-09-16 12:11:07 PDT
Currently Chromium's GraphicsContext3DInternal, which holds the data members for the GraphicsContext3D implementation, is hidden within the GraphicsContext3D.cpp file. It is going to be necessary to add some accessors to this class which can be called from external code (specifically, the WebViewImpl), so it needs to be exposed in its own header.
Comment 1 Kenneth Russell 2010-09-16 12:15:31 PDT
Created attachment 67827 [details]
Comment 2 James Robinson 2010-09-16 12:18:49 PDT
Comment on attachment 67827 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=67827&action=prettypatch


> WebKit/chromium/src/GraphicsContext3DInternal.h:51
> +    bool initialize(GraphicsContext3D::Attributes attrs, HostWindow* hostWindow);

nit: don't name these params

> WebKit/chromium/src/GraphicsContext3DInternal.h:62
> +    void paintRenderingResultsToCanvas(CanvasRenderingContext* context);

nit: don't name param
Comment 3 Kenneth Russell 2010-09-16 12:31:39 PDT
Committed r67650: <http://trac.webkit.org/changeset/67650>