Bug 45881 – [Qt] Use PlatformStrategies to not break WebKit2

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Platform

[Balazs Kelemen]

There is a long standing bug that prevents us to have a working WebKit2 port in trunk.
At http://trac.webkit.org/browser/trunk/WebCore/plugins/qt/PluginDataQt.cpp#L37 there is a cast that is invalid and crashing in WebKit2. The functionality of that piece of code is implementing the QWebPluginFactory API. For not breaking WebKit2 we should implement that in the WebKit level. We can do this with the help of PlatformStrategies (exactly PluginStrategy).

[Balazs Kelemen]

Created attachment 67786 [details]
proposed patch

[WebKit Review Bot]

Attachment 67786 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp"
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 67786 [details]
proposed patch

> -    Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
> -    Copyright (C) 2008 Collabora Ltd. All rights reserved.
> ...
> + * Copyright (C) 2009, 2010 University of Szeged

I don't think this is entirely kosher, you're reusing code but removing the original copyright notices AND changing the license from LGPL to 2cBSD.

[Balazs Kelemen]

Created attachment 67790 [details]
proposed patch v2

Fixed copyrights.

[Balazs Kelemen]

(In reply to comment #3)
> (From update of attachment 67786 [details])
> > -    Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
> > -    Copyright (C) 2008 Collabora Ltd. All rights reserved.
> > ...
> > + * Copyright (C) 2009, 2010 University of Szeged
> 
> I don't think this is entirely kosher, you're reusing code but removing the original copyright notices AND changing the license from LGPL to 2cBSD.

Sorry for that, I did it accidentally.

[WebKit Review Bot]

Attachment 67790 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp"
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Balazs Kelemen]

*** This bug has been marked as a duplicate of bug 45831 ***