http://trac.webkit.org/changeset/67432 added a parameter to suspendActiveDOMObjects so classes that derive from ActiveDOMObject can tell why suspend() is being called. See https://bugs.webkit.org/show_bug.cgi?id=45688. I broke DumpRenderTreeSupportQt with this change, but don't know enough about how it works to fix it correctly, so based on the comments in http://trac.webkit.org/changeset/52914 I am hard coding it to pass ActiveDOMObject::JavaScriptPaused for now.
Created attachment 67517 [details] patch
Comment on attachment 67517 [details] patch LGTM. r=me
(In reply to comment #2) > (From update of attachment 67517 [details]) > LGTM. > r=me I am assuming WebCore/dom/ActiveDOMObject.h gets included by someone...
Temporary fix landed in http://trac.webkit.org/changeset/67440
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 67517 [details] [details]) > > LGTM. > > r=me > > I am assuming WebCore/dom/ActiveDOMObject.h gets included by someone... So, it will get included by WorkerThread.h, which includes WorkerRunLoop.h which includes ScriptExecutionContext.h, which includes ActiveDOMObject.h I was a bit to quick when reviewing this. The enum value JavaScriptPaused was renamed to JavaScriptDebuggerPaused. I missed that in the review. My mistake. I will be more cautious.
Committed enum value fix up in changeset 67442 <http://trac.webkit.org/changeset/67442>.
Attachment 67517 [details] was posted by a committer and has review+, assigning to Eric Carlson for commit.
I committed https://bugs.webkit.org/attachment.cgi?id=67517, and dbates fixed it in http://trac.webkit.org/changeset/67442 when my change didn't actually compile :-( This bug is about getting a real fix into DumpRenderTreeSupportQt::suspendActiveDOMObjects instead of the hack I added which hard codes the reason for suspension.
This actually looks like dead code by now.