Bug 45688 - JavaScript dialog should not deactivate media element
Summary: JavaScript dialog should not deactivate media element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 11:14 PDT by Eric Carlson
Modified: 2010-09-13 19:51 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (17.42 KB, patch)
2010-09-13 11:26 PDT, Eric Carlson 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-09-13 11:14:48 PDT 
The fix for 45306 made media elements derive from ActiveDOMObject so an element can prevent its wrapper object from being collected while it has events in the pending queue. An unintended side effect of this change is a media element is now deactivated when a JavaScript dialog is shown, because ActiveDOMObject::suspend is called just before a dialog is shown.
Comment 1 Eric Carlson 2010-09-13 11:26:46 PDT 
Created attachment 67439 [details]
Proposed patch
Comment 2 Geoffrey Garen 2010-09-13 13:17:01 PDT 
Comment on attachment 67439 [details]
Proposed patch

 51         enum ReasonForSuspension {
 52             JavaScriptPaused,
 53             WillShowDialog,
 54             DocumentWillBecomeInactive
 55         };

"JavaScriptPaused" is a bit vague. How about "JavaScriptDebuggerPaused" instead?

r=me
Comment 3 Eric Carlson 2010-09-13 19:43:07 PDT 
http://trac.webkit.org/changeset/67432
Comment 4 WebKit Review Bot 2010-09-13 19:51:19 PDT 
http://trac.webkit.org/changeset/67432 might have broken Qt Linux Release minimal