Bug 45717 - chromium/skia: possible crash in ImageLayerChromium
Summary: chromium/skia: possible crash in ImageLayerChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
: 45869 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-13 16:17 PDT by Nico Weber
Modified: 2010-09-16 08:58 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch for both Skia and CG (5.57 KB, patch)
2010-09-15 19:48 PDT, Vangelis Kokkevis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2010-09-13 16:17:50 PDT 
Like https://bugs.webkit.org/show_bug.cgi?id=45714 , but for skia. The problem is that the dom owns the image, and when the image is removed from the dom, the layer tree is updated only asynchronously. Hence, the layer needs to ref the platform image.
Comment 1 Nico Weber 2010-09-14 10:21:54 PDT 
Mac version of this bug is now fixed. This skia bug is still missing.
Comment 2 Nico Weber 2010-09-15 19:42:54 PDT 
*** Bug 45869 has been marked as a duplicate of this bug. ***
Comment 3 Vangelis Kokkevis 2010-09-15 19:48:30 PDT 
Created attachment 67764 [details]
Proposed patch for both Skia and CG
Comment 4 WebKit Commit Bot 2010-09-16 08:58:53 PDT 
Comment on attachment 67764 [details]
Proposed patch for both Skia and CG

Clearing flags on attachment: 67764

Committed r67625: <http://trac.webkit.org/changeset/67625>
Comment 5 WebKit Commit Bot 2010-09-16 08:58:58 PDT 
All reviewed patches have been landed.  Closing bug.